search

ropensci / rnoaa

R interface to many NOAA data APIs
https://docs.ropensci.org/rnoaa
Other
330 stars 84 forks source link

ghcnd_splitvars Broken with `dplyr` v0.5.0 #156

Closed lawinslow closed 8 years ago

lawinslow commented 8 years ago

After upgrading dplyr to v0.5.0 (current CRAN version), the rnoaa::ghcnd_splitvars function no longer works. 

> minoc = ghcnd_splitvars(ghcnd('USC00475516'))
Error in is.string(match) : argument "match" is missing, with no default

Seems to fail right away on this select statement.

Downgraded to dplyr v0.4.3 and it works fine.

lawinslow commented 8 years ago

Small world @sckott. Thanks for the noaa package.

sckott commented 8 years ago

thanks @lawinslow - sorry about that - i knew a new version was coming, should have caught it, will push a change soon - added new milestone for bug fixes https://github.com/ropensci/rnoaa/milestones/v0.5.8

lawinslow commented 8 years ago

np, just thought you'd like to know.

sckott commented 8 years ago

@lawinslow try again after reinstall

lawinslow commented 8 years ago

Great. Fixed. Thanks!