ropensci / rnoaa

R interface to many NOAA data APIs
https://docs.ropensci.org/rnoaa
Other
330 stars 84 forks source link

Additions from ROpenSci Unconference (Spring 2016) #159

Closed geanders closed 8 years ago

geanders commented 8 years ago

This pull requests incorporates work started at the spring's ROpenSci Unconference. Specific elements of this pull request are:

sckott commented 8 years ago

@geanders thanks for the PR - made a few comments for changes

geanders commented 8 years ago

Thanks so much for taking the time to review. I've made the suggested changes.

sckott commented 8 years ago

thanks @geanders merged

geanders commented 8 years ago

Thank you so much! I really appreciate you taking the time on this pull request.

Would you let me know the next time you submit a version of rnoaa to CRAN? I have a student working on a package that builds on some of these functions, so it will be good to know for getting the dependencies straight in her package code.

Best,

Brooke


From: Scott Chamberlain notifications@github.com Sent: Tuesday, August 23, 2016 1:11:11 PM To: ropensci/rnoaa Cc: Anderson,Brooke; Mention Subject: Re: [ropensci/rnoaa] Additions from ROpenSci Unconference (Spring 2016) (#159)

thanks @geandershttps://github.com/geanders merged

You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/ropensci/rnoaa/pull/159#issuecomment-241843978, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFVFiHV-MeqEczU_Bt8juzgC65I7Iwsmks5qi0XPgaJpZM4JkmdY.

sckott commented 8 years ago

thanks for all your work on this, and the work of others, i'll add you as a contributor