search

ropensci / rnoaa

R interface to many NOAA data APIs
https://docs.ropensci.org/rnoaa
Other
330 stars 84 forks source link

ISD Precipitation data missing #176

Closed mrubayet closed 7 years ago

mrubayet commented 7 years ago

I don't think isd() can retrieve precipitation data. I guess you have missed the additional data described in: ftp://ftp.ncdc.noaa.gov/pub/data/noaa/ish-format-document.pdf. isd() retrieves only mandatory section however precipitation falls in the additional part of the data set.

sckott commented 7 years ago

thanks @mrubayet

i did indeed miss some data. i got some of the additional data, but not all. I'm working on that.

also, breaking off the ISD parser to a new pkg https://github.com/ropenscilabs/isdparser (so users don't need some of the heavier deps of rnoaa) - rnoaa will use it once on cran

mrubayet commented 7 years ago

Great. Also please check the unit of precipitation in rnoaa documentation for meteo_tidy_ghcnd (). The unit isn't consistent for input var and the value. I think the output precipitation should be also in tenths of millimeters. Thanks

sckott commented 7 years ago

Also please check the unit of precipitation in rnoaa documentation for meteo_tidy_ghcnd (). The unit isn't consistent for input var and the value. I think the output precipitation should be also in tenths of millimeters

Please open a new issue for this since that deals with ghcnd data - and give example please

sckott commented 7 years ago

closing, should be all fixed now