ropensci / rnoaa

R interface to many NOAA data APIs
https://docs.ropensci.org/rnoaa
Other
330 stars 84 forks source link

isd data extraction error #188

Closed soms1 closed 7 years ago

soms1 commented 7 years ago

I could successfully download hourly surface data for many years. For some years as in the example below, rnoaa shows error like this:

res1<-isd(usaf="724839",wban="93225",year=1991)

"Error in stats::setNames(tmp, nms) : 'names' attribute [11] must be the same length as the vector [8]"

I just need 1 or 2 variables to download.

Thanks

sckott commented 7 years ago

thanks for the issue. please paste in your devtools::session_info() or sessionInfo()

soms1 commented 7 years ago

Here it is. Thank you!

sessionInfo() R version 3.3.2 (2016-10-31) Platform: i386-w64-mingw32/i386 (32-bit) Running under: Windows 7 x64 (build 7601) Service Pack 1

locale: [1] LC_COLLATE=English_United States.1252 LC_CTYPE=English_United States.1252
[3] LC_MONETARY=English_United States.1252 LC_NUMERIC=C
[5] LC_TIME=English_United States.1252

attached base packages: [1] stats graphics grDevices utils datasets methods base

other attached packages: [1] plyr_1.8.4 rnoaa_0.6.6 downloader_0.4 ggplot2_2.2.1 dplyr_0.5.0

loaded via a namespace (and not attached): [1] Rcpp_0.12.8 xml2_1.0.0 magrittr_1.5 rappdirs_0.3.1 munsell_0.4.3
[6] colorspace_1.3-2 R6_2.2.0 isdparser_0.1.0 stringr_1.1.0 httr_1.2.1
[11] tools_3.3.2 grid_3.3.2 gtable_0.2.0 DBI_0.5-1 lazyeval_0.2.0
[16] assertthat_0.1 digest_0.6.10 tibble_1.2 gridExtra_2.2.1 tidyr_0.6.0
[21] curl_2.3 stringi_1.1.2 scales_0.4.1 XML_3.98-1.5 jsonlite_1.1
[26] lubridate_1.6.0

sckott commented 7 years ago

that's taken care of in the development version of isdparser - see https://github.com/ropensci/isdparser/issues/9 install it from github devtools::install_github("ropensci/isdparser")

trying to get new isdparser to CRAN soon

sckott commented 7 years ago

closing due to inactivity, i assume this is sorted