search

ropensci / rnoaa

R interface to many NOAA data APIs
https://docs.ropensci.org/rnoaa
Other
330 stars 84 forks source link

updates ropenaq vignette #209

Closed maelle closed 7 years ago

maelle commented 7 years ago

I updated the ropenaq code in the vignette because it can now be simpler.

I've noticed an issue with the unit in the tables. I'm unsure about what caused this encoding problem, and my first name seems to be ok. Any idea?

sckott commented 7 years ago

thanks @maelle ! looks good. I'll try to fix encoding after merging. is that okay?

maelle commented 7 years ago

Of course, thank you!

sckott commented 7 years ago

reran the vignette on my machine, https://github.com/ropensci/rnoaa/blob/master/vignettes/rnoaa_ropenaq.Rmd looks okay i think, although the first table is a bit wide, and at least in Rstudio, looks awkward, maybe dates can be shortened

maelle commented 7 years ago

Thanks a lot! It's wide but ok thanks to scrolling ?