argo_buoy_files() is broken

[jonmcalder]

Presumably the endpoint has changed slightly since argo_buoy_files() hits an index page and isn't parsing the html wrapping the file list (see below reprex).

library(rnoaa)
argo_buoy_files(dac = "bodc", id = 1901309)
#> Error in scan(file = file, what = what, sep = sep, quote = quote, dec = dec, : line 2 did not have 5 elements

Session info

``` r devtools::session_info() #> Session info ------------------------------------------------------------- #> setting value #> version R version 3.3.2 (2016-10-31) #> system x86_64, mingw32 #> ui RTerm #> language (EN) #> collate English_South Africa.1252 #> tz Africa/Johannesburg #> date 2017-10-14 #> Packages ----------------------------------------------------------------- #> package * version date source #> assertthat 0.2.0 2017-04-11 CRAN (R 3.3.3) #> backports 1.1.0 2017-05-22 CRAN (R 3.3.3) #> base * 3.3.2 2016-10-31 local #> bindr 0.1 2016-11-13 CRAN (R 3.3.3) #> bindrcpp 0.2 2017-06-17 CRAN (R 3.3.3) #> colorspace 1.3-2 2016-12-14 CRAN (R 3.3.2) #> datasets * 3.3.2 2016-10-31 local #> devtools 1.13.3 2017-08-02 CRAN (R 3.3.3) #> digest 0.6.12 2017-01-27 CRAN (R 3.3.3) #> dplyr 0.7.4 2017-09-28 CRAN (R 3.3.3) #> evaluate 0.10.1 2017-06-24 CRAN (R 3.3.3) #> ggplot2 2.2.1.9000 2017-09-12 Github (tidyverse/ggplot2@c592e32) #> glue 1.1.1 2017-06-21 CRAN (R 3.3.3) #> graphics * 3.3.2 2016-10-31 local #> grDevices * 3.3.2 2016-10-31 local #> grid 3.3.2 2016-10-31 local #> gridExtra 2.3 2017-09-09 CRAN (R 3.3.3) #> gtable 0.2.0 2016-02-26 CRAN (R 3.3.0) #> hoardr 0.2.0 2017-05-10 CRAN (R 3.3.3) #> htmltools 0.3.6 2017-04-28 CRAN (R 3.3.3) #> httr 1.3.1 2017-08-20 CRAN (R 3.3.3) #> jsonlite 1.5 2017-06-01 CRAN (R 3.3.3) #> knitr 1.17 2017-08-10 CRAN (R 3.3.3) #> lazyeval 0.2.0 2016-06-12 CRAN (R 3.3.0) #> lubridate 1.6.0 2016-09-13 CRAN (R 3.3.1) #> magrittr 1.5 2014-11-22 CRAN (R 3.3.0) #> memoise 1.1.0 2017-04-21 CRAN (R 3.3.3) #> methods * 3.3.2 2016-10-31 local #> munsell 0.4.3 2016-02-13 CRAN (R 3.3.0) #> pkgconfig 2.0.1 2017-03-21 CRAN (R 3.3.3) #> plyr 1.8.4 2016-06-08 CRAN (R 3.3.1) #> purrr 0.2.3 2017-08-02 CRAN (R 3.3.3) #> R6 2.2.2 2017-06-17 CRAN (R 3.3.3) #> rappdirs 0.3.1 2016-03-28 CRAN (R 3.3.3) #> Rcpp 0.12.13 2017-09-28 CRAN (R 3.3.3) #> rlang 0.1.2.9000 2017-09-26 Github (tidyverse/rlang@99105b6) #> rmarkdown 1.6 2017-06-15 CRAN (R 3.3.3) #> rnoaa * 0.7.0.9105 2017-10-07 Github (ropensci/rnoaa@d76e623) #> rprojroot 1.2 2017-01-16 CRAN (R 3.3.2) #> scales 0.5.0 2017-08-24 CRAN (R 3.3.3) #> stats * 3.3.2 2016-10-31 local #> stringi 1.1.5 2017-04-07 CRAN (R 3.3.3) #> stringr 1.2.0 2017-02-18 CRAN (R 3.3.3) #> tibble 1.3.4 2017-08-22 CRAN (R 3.3.3) #> tidyr 0.7.1 2017-09-01 CRAN (R 3.3.3) #> tools 3.3.2 2016-10-31 local #> utils * 3.3.2 2016-10-31 local #> withr 2.0.0 2017-09-12 Github (jimhester/withr@f378851) #> XML 3.98-1.9 2017-06-19 CRAN (R 3.3.3) #> xml2 1.1.9000 2017-10-07 Github (hadley/xml2@5799cd9) #> yaml 2.1.14 2016-11-12 CRAN (R 3.3.2) ```

[sckott]

thanks, i can't replicate that problem locally on osx, will look at tomorrow

but i do see problems in other argo fxns, e.g., argo_search() is always failing with too many connections - it's not an R problem, it may clear up soon if it's a server problem on their end

[sckott]

okay, check on rhub windows was able to replicate https://builder.r-hub.io/status/rnoaa_0.7.0.9105.tar.gz-48c7cc1bb64447919089bd8f97cfd32f#L7329

[sckott]

@jonmcalder not sure if you've already given up, but should be working now, tested on rhub windows at least

[jonmcalder]

Sorry haven't looked at this for ages - do you need/want me to check it?

[sckott]

If you have time/interest, please do and let me know. I tested on windows Rhub - but haven't checked on other windows environments

[jonmcalder]

Just checked and seems to be fine on my home Windows machine 👍

[sckott]

great, thanks for checking!