Add some tests (see #208)

ropensci / rnoaa

R interface to many NOAA data APIs

https://docs.ropensci.org/rnoaa

Other

330 stars 84 forks source link

Add some tests (see #208) #236

Closed jonmcalder closed 7 years ago

jonmcalder commented 7 years ago

These are very basic - just trying to get the ball rolling for now.

jonmcalder commented 7 years ago

9 failed tests :-(

All of which seem (at least on the surface) to be unrelated to the test additions in this PR? @sckott I assume these are the kinds of failures you referred to previously due to environment variables not being available in CI for PR's?

sckott commented 7 years ago

yes, those failures pretty sure are due to that env var issue. so no worries on those,

I'll have a look

sckott commented 7 years ago

LGTM