`autoplot.meteo_coverage` not working, error with ggplot2

[sckott]

thoughts @geanders ?

monitors <- c("ASN00095063", "ASN00024025", "ASN00040112", "ASN00041023",
             "ASN00009998", "ASN00066078", "ASN00003069", "ASN00090162",
             "ASN00040126", "ASN00058161")
obs <- meteo_pull_monitors(monitors)
obs_covr <- meteo_coverage(obs)
library("ggplot2")
autoplot(obs_covr)

gives

Error in FUN(X[[i]], ...) : object '.group' not found
In addition: Warning messages:
1: `panel.margin` is deprecated. Please use `panel.spacing` property instead
2: `panel.margin.x` is deprecated. Please use `panel.spacing.x` property instead
3: `panel.margin` is deprecated. Please use `panel.spacing` property instead
4: `panel.margin` is deprecated. Please use `panel.spacing` property instead

Session Info

```r R version 3.4.3 Patched (2018-01-01 r74017) Platform: x86_64-apple-darwin15.6.0 (64-bit) Running under: macOS High Sierra 10.13.3 Matrix products: default BLAS: /Library/Frameworks/R.framework/Versions/3.4/Resources/lib/libRblas.0.dylib LAPACK: /Library/Frameworks/R.framework/Versions/3.4/Resources/lib/libRlapack.dylib locale: [1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8 attached base packages: [1] stats graphics grDevices utils datasets methods base other attached packages: [1] ggplot2_2.2.1.9000 bindrcpp_0.2 testthat_2.0.0 rnoaa_0.7.1.9149 loaded via a namespace (and not attached): [1] Rcpp_0.12.15 compiler_3.4.3 pillar_1.1.0 plyr_1.8.4 [5] bindr_0.1 geonames_0.998 tools_3.4.3 digest_0.6.15 [9] lubridate_1.7.2 jsonlite_1.5 memoise_1.1.0 tibble_1.4.2 [13] gtable_0.2.0 pkgconfig_2.0.1 rlang_0.2.0 rstudioapi_0.7 [17] cli_1.0.0 commonmark_1.4 crul_0.5.0 curl_3.1 [21] gridExtra_2.3 withr_2.1.1.9000 dplyr_0.7.4 httr_1.3.1 [25] stringr_1.3.0.9000 roxygen2_6.0.1 xml2_1.2.0 devtools_1.13.5 [29] rappdirs_0.3.1 tidyselect_0.2.3 grid_3.4.3 glue_1.2.0 [33] R6_2.2.2 XML_3.98-1.10 hoardr_0.2.0.9100 isdparser_0.2.0 [37] tidyr_0.8.0 purrr_0.2.4 magrittr_1.5 scales_0.5.0.9000 [41] assertthat_0.2.0 mime_0.5 colorspace_1.3-2 utf8_1.1.3 [45] stringi_1.1.6 lazyeval_0.2.1 munsell_0.4.3 crayon_1.3.4 ```

[jsta]

This can likely be solved by either using inherit.aes=FALSE or ungroup(obs). See https://github.com/mjskay/tidybayes/issues/100

[sckott]

thanks a ton @jsta 👍

[geanders]

Sorry to be late to the conversation. Agreed, thanks @jsta!

[sckott]

@geanders feel free to make any changes that you think are better - i'm most definitely not an experienced ggplot2 user

[geanders]

Sure, I'll take a look. I can't remember off the top of my head if this function will potentially be passed anything that's not grouped and, if so, if running ungroup on something without grouping has the potential to cause any problems here.

[sckott]

if running ungroup on something without grouping has the potential to cause any problems here.

agree, i worry that could cause problems, not sure