search

ropensci / rnoaa

R interface to many NOAA data APIs
https://docs.ropensci.org/rnoaa
Other
330 stars 84 forks source link

trouble retrieving GSOY data w/ ncdc() #279

Closed ghaines3 closed 6 years ago

ghaines3 commented 6 years ago

Hi all, I'm having a bit of trouble getting data from just the GSOY dataset. I don't think it's a problem with the code I'm using, because it works just fine for the GSOM dataset, but I get an error when I switch the M to a Y. I'm fairly new to R, so this may be a fairly simple mistake, but any help figuring out what is going on here would be much appreciated.

Here is the code I am using that works just fine for the GSOM data:

>ncdc(datasetid = "GSOM", stationid = "GHCND:UK000056225", token ="____",
              startdate = "2010-01-01", enddate = "2015-12-31")

But when I try to get data from the GSOY dataset, I get an error message:

> ncdc(datasetid = "GSOY", stationid = "GHCND:UK000056225", token ="____",
              startdate = "2010-01-01", enddate = "2015-12-31")
Error in strsplit(y, ",") : non-character argument

cheers!

Session Info ```r R version 3.4.3 (2017-11-30) Platform: x86_64-apple-darwin15.6.0 (64-bit) Running under: macOS High Sierra 10.13.6 Matrix products: default BLAS: /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib LAPACK: /Library/Frameworks/R.framework/Versions/3.4/Resources/lib/libRlapack.dylib locale: [1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8 attached base packages: [1] stats graphics grDevices utils datasets methods base other attached packages: [1] bindrcpp_0.2.2 data.table_1.11.6 plyr_1.8.4 rnoaa_0.7.0 [5] geosphere_1.5-7 rlist_0.4.6.1 tidyr_0.8.1 loaded via a namespace (and not attached): [1] Rcpp_0.12.18 pillar_1.1.0 compiler_3.4.3 bindr_0.1.1 [5] tools_3.4.3 digest_0.6.14 jsonlite_1.5 lubridate_1.7.4 [9] tibble_1.4.1 gtable_0.2.0 lattice_0.20-35 pkgconfig_2.0.1 [13] rlang_0.2.2 cli_1.0.0 curl_3.2 gridExtra_2.3 [17] xml2_1.2.0 dplyr_0.7.6 httr_1.3.1 stringr_1.2.0 [21] rappdirs_0.3.1 grid_3.4.3 tidyselect_0.2.4 glue_1.3.0 [25] R6_2.2.2 XML_3.98-1.16 sp_1.3-1 hoardr_0.2.0 [29] ggplot2_2.2.1 purrr_0.2.5 magrittr_1.5 scales_0.5.0 [33] assertthat_0.2.0 mime_0.5 colorspace_1.3-2 utf8_1.1.3 [37] stringi_1.1.6 lazyeval_0.2.1 munsell_0.4.3 crayon_1.3.4 ```
sckott commented 6 years ago

thanks for this @ghaines3

looks like a bug. i just pushed up a change that I think fixes it. reinstall remotes::install_github("ropensci/rnoaa") and try again after restarting session

ghaines3 commented 6 years ago

Awesome, thanks very much!