Closed philipshirk closed 4 years ago
The travis-ci check keeps failing, but it appears to be related to test-ncdc_datacats.r
. When I run devtools::test(pkg = '.', filter = 'meteo')
on my machine it passes. I don't think I've changed anything relevant to the test-ncdc_datacats.r
check.
Don't worry about the ncdc*
test errors as those require an API key, and the API key stored with Travis is not availiable on pull requests.
There's a number of issues in the check related to your changes https://travis-ci.org/github/ropensci/rnoaa/jobs/660316966#L1693-L1720
all_of
come from?na.omit
like stats::na.omit
"metric"
and "size"
in the vector of globals https://github.com/ropensci/rnoaa/blob/master/R/globals.RI fixed the things that you mentioned, @sckott, and I think it's working now. I searched the travis logs for "meteo_coverage" and "autoplot" and don't see any more problems. Let me know if you find any.
looks good, thanks @philipshirk !
Description
meteo_utils
data.frame
as beforedata.frame
that is the same format as the inputdata.frame
but with extra rows added so that there is a row for each date between the earliest data point and the latest data point.data.frames
are added to a list for outputmeteo-autoplot
tidyr
, so hopefully that's not an issue anymore.ggplot2::geom_line
because it will automatically removeNA
s and display gaps in the data. It's pretty slow with large datasets, so it might not be the best long-term solution.ggplot2
uses to calculate line widths and locations, so I used guess-and-check to set line widths andggplot2::position_dodge
amount.Related Issue
This is to "fix" issue #314
Example