New coverage plots that include gaps for missing data.

[philipshirk]

Description

meteo_utils

• still creates same data.frame as before
• also creates additional data.frame that is the same format as the input data.frame but with extra rows added so that there is a row for each date between the earliest data point and the latest data point.
• both data.frames are added to a list for output

meteo-autoplot

• added an argument to the function to allow the user to choose between the plot that does not visually display gaps in data and a plot that does.
• I used 'tidyr::pivot_longer' in the function. I've had some issues with that function on some computers before. I think it was related to the version of tidyr, so hopefully that's not an issue anymore.
• I plot the data with ggplot2::geom_line because it will automatically remove NAs and display gaps in the data. It's pretty slow with large datasets, so it might not be the best long-term solution.
• I haven't been able to figure out the technique ggplot2 uses to calculate line widths and locations, so I used guess-and-check to set line widths and ggplot2::position_dodge amount.

Related Issue

This is to "fix" issue #314

Example

library(rnoaa)

# Sites
id1 <-  'USC00367732'
id2  <- 'USC00084289'
id3  <- 'USW00014895'

# get data
dat <- meteo_pull_monitors(monitors =  c(id1, id2, id3), 
                           keep_flags = T, 
                           var = c("PRCP", "TMIN", "TMAX", 'TAVG'))

obs_covr <- meteo_coverage(meteo_df = dat, verbose = TRUE)

autoplot(obs_covr, old_style = TRUE)
autoplot(obs_covr, old_style = FALSE)

[philipshirk]

The travis-ci check keeps failing, but it appears to be related to test-ncdc_datacats.r. When I run devtools::test(pkg = '.', filter = 'meteo') on my machine it passes. I don't think I've changed anything relevant to the test-ncdc_datacats.r check.

[sckott]

Don't worry about the ncdc* test errors as those require an API key, and the API key stored with Travis is not availiable on pull requests.

There's a number of issues in the check related to your changes https://travis-ci.org/github/ropensci/rnoaa/jobs/660316966#L1693-L1720

• input vs. object
• where does all_of come from?
• use na.omit like stats::na.omit
• put "metric" and "size" in the vector of globals https://github.com/ropensci/rnoaa/blob/master/R/globals.R

[philipshirk]

I fixed the things that you mentioned, @sckott, and I think it's working now. I searched the travis logs for "meteo_coverage" and "autoplot" and don't see any more problems. Let me know if you find any.

[sckott]

looks good, thanks @philipshirk !