Speeds up ghcn_splitvars

ropensci / rnoaa

R interface to many NOAA data APIs

https://docs.ropensci.org/rnoaa

Other

328 stars 84 forks source link

Closed eliocamp closed 4 years ago

eliocamp commented 4 years ago

Changes a lot of dplyr data manipulation into a data.table::melt(). This makes ghcn_splitvars() considerably faster.

Closes #352

sckott commented 4 years ago

can you incorporate the latest commit from master to your branch - then I'll take a look

eliocamp commented 4 years ago

can you incorporate the latest commit from master to your branch - then I'll take a look

Sorry, I'm still a git novice. The git graph is showing me that this branch is based on current master. What am I missing?

sckott commented 4 years ago

ah nevermind, was looking at rebase, but we can merge