ropensci / rnoaa

R interface to many NOAA data APIs
https://docs.ropensci.org/rnoaa
Other
328 stars 84 forks source link

retire ropenaq vignette? #366

Open maelle opened 4 years ago

maelle commented 4 years ago

:wave: @sckott! I have to release a new version of ropenaq and was looking at the vignette. It can't work at the moment because of the API, cf reprex below, lines of the vignette, and issue referenced.

measurementsIndianapolis <- ropenaq::aq_measurements(city = "Indianapolis", parameter = "pm25",
                                            date_from = as.character(Sys.Date() - 30),
                                            date_to = as.character(Sys.Date()),
                                            limit = 10000 )
measurementsIndianapolis$dateLocal
#> Warning: Unknown or uninitialised column: `dateLocal`.
#> NULL

Created on 2020-07-27 by the reprex package (v0.3.0)

https://github.com/ropensci/rnoaa/blob/affaacc04c067d5c317d1f0a90b0f514525890f6/vignettes/rnoaa_ropenaq.Rmd#L54-L59

https://github.com/openaq/openaq-api/issues/450

I am sorry!

sckott commented 4 years ago

thanks @maelle - can we just use the other date field? dateUTC ?

maelle commented 4 years ago

I think you can but then the day isn't necessarily the correct one.

sckott commented 4 years ago

ok, i'm not familiar enough with the vignette to make changes. maybe we can look at this when you get back from vacation

maelle commented 4 years ago

Yes and hopefully the API will be fixed in the meantime!

maelle commented 3 years ago

The API was fixed but I am getting another error

rnoaa::ghcnd_stations()
#> Error in curl::curl_fetch_disk(x$url$url, x$disk, handle = x$url$handle): response reading failed

Created on 2020-10-12 by the reprex package (v0.3.0.9001)

Session info ``` r sessioninfo::session_info() #> ─ Session info ─────────────────────────────────────────────────────────────── #> setting value #> version R version 4.0.2 (2020-06-22) #> os Ubuntu 20.04.1 LTS #> system x86_64, linux-gnu #> ui X11 #> language (EN) #> collate fr_FR.UTF-8 #> ctype fr_FR.UTF-8 #> tz Europe/Paris #> date 2020-10-12 #> #> ─ Packages ─────────────────────────────────────────────────────────────────── #> package * version date lib source #> assertthat 0.2.1 2019-03-21 [3] CRAN (R 4.0.0) #> cli 2.0.2 2020-02-28 [3] CRAN (R 4.0.0) #> colorspace 1.4-1 2019-03-18 [3] CRAN (R 4.0.0) #> crayon 1.3.4 2017-09-16 [3] CRAN (R 4.0.0) #> crul 1.0.0 2020-07-30 [1] CRAN (R 4.0.2) #> curl 4.3 2019-12-02 [3] CRAN (R 4.0.0) #> digest 0.6.25 2020-02-23 [3] CRAN (R 4.0.0) #> dplyr 1.0.2 2020-08-18 [1] CRAN (R 4.0.2) #> ellipsis 0.3.1 2020-05-15 [3] CRAN (R 4.0.0) #> evaluate 0.14 2019-05-28 [3] CRAN (R 4.0.0) #> fansi 0.4.1 2020-01-08 [3] CRAN (R 4.0.0) #> fs 1.5.0 2020-07-31 [3] CRAN (R 4.0.2) #> generics 0.0.2 2018-11-29 [1] CRAN (R 4.0.2) #> ggplot2 3.3.2 2020-06-19 [3] CRAN (R 4.0.1) #> glue 1.4.2 2020-08-27 [1] CRAN (R 4.0.2) #> gridExtra 2.3 2017-09-09 [1] CRAN (R 4.0.2) #> gtable 0.3.0 2019-03-25 [3] CRAN (R 4.0.0) #> highr 0.8 2019-03-20 [3] CRAN (R 4.0.0) #> hoardr 0.5.2 2018-12-02 [1] CRAN (R 4.0.2) #> htmltools 0.5.0 2020-06-16 [3] CRAN (R 4.0.1) #> httpcode 0.3.0 2020-04-10 [1] CRAN (R 4.0.2) #> jsonlite 1.7.1 2020-09-07 [1] CRAN (R 4.0.2) #> knitr 1.30 2020-09-22 [3] CRAN (R 4.0.2) #> lifecycle 0.2.0 2020-03-06 [3] CRAN (R 4.0.0) #> lubridate 1.7.9 2020-06-08 [1] CRAN (R 4.0.2) #> magrittr 1.5 2014-11-22 [3] CRAN (R 4.0.0) #> munsell 0.5.0 2018-06-12 [3] CRAN (R 4.0.0) #> pillar 1.4.6 2020-07-10 [3] CRAN (R 4.0.2) #> pkgconfig 2.0.3 2019-09-22 [3] CRAN (R 4.0.0) #> purrr 0.3.4 2020-04-17 [3] CRAN (R 4.0.0) #> R6 2.4.1 2019-11-12 [3] CRAN (R 4.0.0) #> rappdirs 0.3.1 2016-03-28 [1] CRAN (R 4.0.2) #> Rcpp 1.0.5 2020-07-06 [3] CRAN (R 4.0.2) #> reprex 0.3.0.9001 2020-08-19 [1] Github (tidyverse/reprex@23a3462) #> rlang 0.4.8 2020-10-08 [1] CRAN (R 4.0.2) #> rmarkdown 2.4.2 2020-10-12 [1] Github (rstudio/rmarkdown@cd0ca7f) #> rnoaa 1.2.0 2020-10-12 [1] local #> scales 1.1.1 2020-05-11 [3] CRAN (R 4.0.0) #> sessioninfo 1.1.1 2018-11-05 [3] CRAN (R 4.0.0) #> stringi 1.5.3 2020-09-09 [1] CRAN (R 4.0.2) #> stringr 1.4.0 2019-02-10 [3] CRAN (R 4.0.0) #> tibble 3.0.3 2020-07-10 [3] CRAN (R 4.0.2) #> tidyr 1.1.2 2020-08-27 [1] CRAN (R 4.0.2) #> tidyselect 1.1.0 2020-05-11 [1] CRAN (R 4.0.2) #> triebeard 0.3.0 2016-08-04 [1] CRAN (R 4.0.2) #> urltools 1.7.3 2019-04-14 [1] CRAN (R 4.0.2) #> vctrs 0.3.4 2020-08-29 [1] CRAN (R 4.0.2) #> withr 2.3.0 2020-09-22 [3] CRAN (R 4.0.2) #> xfun 0.18 2020-09-29 [1] CRAN (R 4.0.2) #> XML 3.99-0.5 2020-07-23 [1] CRAN (R 4.0.2) #> xml2 1.3.2.9001 2020-09-12 [1] Github (r-lib/xml2@685bfff) #> yaml 2.2.1 2020-02-01 [3] CRAN (R 4.0.0) #> #> [1] /home/maelle/R/x86_64-pc-linux-gnu-library/4.0 #> [2] /usr/local/lib/R/site-library #> [3] /usr/lib/R/site-library #> [4] /usr/lib/R/library ```
sckott commented 3 years ago

I assume it's temporarily down, will check back in tomorrow to see if it's still down

sckott commented 3 years ago

looks like its back up now @maelle

maelle commented 3 years ago

thanks.

My problems are now

I wonder whether we should just retire the vignette. :thinking:

maelle commented 3 years ago

I removed the ggmap stuff

maelle commented 3 years ago

Is there anything else I can help with? I need to submit ropenaq to CRAN soon.