search

ropensci / roadoi

Use Unpaywall with R
https://docs.ropensci.org/roadoi
Other
64 stars 3 forks source link

add "email" to API call #1

Closed hpiwowar closed 7 years ago

hpiwowar commented 7 years ago

Thanks so much for making this R wrapper, it's fantastic! !!! yay :)

When you get a chance, could you add "email" as a param to the call signature and your usage example, and email=EMAIL to the api request? Tracking the oadoi (via roadoi) usage allows us to get in touch if something breaks, and also means we can report stats to our funders, which helps us keep our non-profit afloat. :) Thanks!

njahn82 commented 7 years ago

Many thanks for your great tool! I added email as a parameter. Hope it works for you

njahn82 commented 7 years ago

Hi @hpiwowar I just want to make sure that the added email parameter and user agent are working for you before submitting it to CRAN. Thanks!

jasonpriem commented 7 years ago

Hey, sorry I'm late the party. Yep those are working great! Thanks for asking. Just one request:

We completely rebuilt a lot of oaDOI over the last month in order to deal with the massive traffic we were getting. As part of that, we found that is was actually easier to scale (using Heroku Dynos) if we got one DOI per request, using the GET endpoint. That's reflected in the new API docs, which no longer mention the POST. It's also for the most part easier for people to use.

So, if you get the chance or have the interest, we'd love if this wrapper could use the GET endpoint as well.

Thanks again for making this...it's so cool! And we've used it ourselves a number of times now, as we work on improving our precision and recall. It's a great, easy way to get quick data on how good we're doing on various subsets of the literature.

njahn82 commented 7 years ago

Thanks for letting me know @jasonpriem . Will implement the GET method. Just to be on the safe side, you will no longer officially support the POST method, so I better mark this function as Defunct?

njahn82 commented 7 years ago

Great to hear that the email parameter works for you, and many thanks for your kind words. I will close this issue. Let's follow up on using the GET endpoint here #3