ropensci / roregistry

ropensci registry
13 stars 5 forks source link

Packages with incorrect GitHub addresses #38

Closed steffilazerte closed 8 months ago

steffilazerte commented 10 months ago

I found two packages in the roregistry registry.json file with incorrect GitHub addresses:

        name                          github
1 commonmark  https://github.github.com/gfm/  # Should be https://github.com/r-lib/commonmark
2       gert https://docs.ropensci.org/gert/  # Should be https://github.com/r-lib/gert
maelle commented 10 months ago

Thank you!

codemetar gives priority to URLs in DESCRIPTION so it picks up the first correct looking one... whereas pkgdown gives more weight to the issue tracker field.

One possible fix: changing DESCRIPTION as in https://github.com/r-lib/commonmark/pull/27

Another fix: special-case these repos in makeregistry.

Yet another fix: suggest updating the logic of {codemetar} and {codemetar}

@jeroen, what do you think?

jeroen commented 10 months ago

I think codemetar should be smart enough to see that the URL in BugReports is a GitHub URL, and the other ones are not.

maelle commented 10 months ago

Actually codemetar is smart enough so it must be a makeregistry problem (codemeta makes the mistake but that's another problem https://github.com/cboettig/codemeta/issues/19 as we don't use it in makeregistry)

maelle commented 10 months ago

ah we do use codemeta :joy:

maelle commented 10 months ago

https://github.com/cboettig/codemeta/pull/20

maelle commented 10 months ago

@steffilazerte how urgently do you need the fix?

steffilazerte commented 10 months ago

Not urgent, I have an easy workaround for now

maelle commented 8 months ago

Fixed :tada: https://github.com/ropensci/roregistry/commit/984dd49101a521ff7a6b4ca3c81bd16107718e1d

Thanks for catching and reporting this!