ropensci / rotl

Interface to Open Tree of Life API
https://docs.ropensci.org/rotl
Other
39 stars 18 forks source link

tol_induced_subtree errors with v3 #74

Closed dwinter closed 8 years ago

dwinter commented 8 years ago

Using the example from the docs we get a neo4j error about casting strings (?) when using rotl

test <- c(292466, 267845, 666104, 316878, 102710)
tol_induced_subtree(ott_ids=test)
Could not convert!BadInputExceptionorg.neo4j.server.rest.repr.BadInputExceptionlist("org.neo4j.server.rest.repr.RepresentationFormat.convertString(RepresentationFormat.java:330)", "org.neo4j.server.rest.repr.RepresentationFormat$1.convertString(RepresentationFormat.java:164)", "org.neo4j.server.plugins.ParameterList.getString(ParameterList.java:86)", "org.neo4j.server.plugins.StringTypeCaster.get(StringTypeCaster.java:30)", "org.neo4j.server.plugins.ParameterExtractor.extract(ParameterExtractor.java:45)", "org.neo4j.server.plugins.PluginMethod.invoke(PluginMethod.java:53)", 

The same examples works fine with curl from command line, so seems like it is something we are doing

curl -X POST https://api.opentreeoflife.org/v3/tree_of_life/induced_subtree -H "content-type:application/json" -d {"ott_ids":[292466, 267845, 666104, 316878, 102710]}'
{
  "newick" : "(((Cinclus_ott26784 ....
}
josephwb commented 8 years ago

Hmm. I'll take a look.

josephwb commented 8 years ago

Ack, it looks like all of my edits were overwritten!

josephwb commented 8 years ago

Ok, found the issue. Not sure what to do about all of my deleted edits, though...

josephwb commented 8 years ago

Fixed with 88e0f6cb03721725967b8c2395a5ece783a690df.