doc: arg tree -> tree_id

ropensci / rotl

Interface to Open Tree of Life API

https://docs.ropensci.org/rotl

Other

39 stars 18 forks source link

doc: arg tree -> tree_id #92

Closed josephwb closed 7 years ago

josephwb commented 7 years ago

Updated examples in studies.R to use real "tree_id" arg instead of "tree" (although both seem to work?!?)

fmichonneau commented 7 years ago

yes it worked, because R does partial matching on function arguments.

josephwb commented 7 years ago

Yeah I figured that out. Still, should have full arg name, right?

fmichonneau commented 7 years ago

yes, definitely! thanks for catching that. Would you mind updating the PR to include the other example you mentioned?

josephwb commented 7 years ago

The subtree/ingroup example?

josephwb commented 7 years ago

Looks like you fixed the subtree/ingroup already (study_id="pg_420", tree_id="tree522").

codecov-io commented 7 years ago

Current coverage is 85.97% (diff: 100%)

Merging #92 into master will not change coverage

@@             master        #92   diff @@
==========================================
  Files            18         18          
  Lines          1198       1198          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1030       1030          
  Misses          168        168          
  Partials          0          0

Powered by Codecov. Last update 9b21d18...7c7b7e9

josephwb commented 7 years ago

I have to run. But I think the example you want is: study_id="pg_1144" tree_id="tree5800" The ingroup node has id: "node991044" I can add this in later, or you can do it.

fmichonneau commented 7 years ago

thanks