ropensci / roweb

:no_entry: [DEPRECATED] Active at https://github.com/ropensci/roweb2
https://legacy.ropensci.org
Other
18 stars 29 forks source link

Adding webrockets runconf17 blog post and 2 associated images. #315

Closed MilesMcBain closed 7 years ago

MilesMcBain commented 7 years ago

Description

Added .md render of our .Rmd file, created an image folder with our images, updated image links

Blog post?

The instructions here didn't quite match https://github.com/ropensci/roweb/blob/master/.github/CONTRIBUTING.md which was sent through by Stef. I went with what was in the link.

MilesMcBain commented 7 years ago

I just noticed that one of our images in on the large side - 3.1mb. We could host externally or try to shrink it down if you need.

stefaniebutland commented 7 years ago

@sckott This post is to go live Wed July 5th. Can you please respond to Miles' comment above about large image? @jeroen has agreed to do merge and render while you're away. Jeroen do you have everything you need to do this?

sckott commented 7 years ago

Looking at post now, will comment on anything I see.

@jeroen just need to add an entry in the yaml header with topicid: XXX, where XXX is the topic id in the slug from our forum - just create a new post like https://discuss.ropensci.org/t/packagemetrics-helping-you-choose-a-package-since-runconf17/759 - and use that number at the end of the URL in the yaml of the blog post - then that's it

sorry it's so janky, had an automated setup linking to forum, but it was duplicating and more the posts, so was really annoying

sckott commented 7 years ago

awesome work @MilesMcBain @AliciaSchep

I don't think the big image is a problem - not sure the emoji will come through though

AliciaSchep commented 7 years ago

For emoji, can we replace the :emoji: syntax with a link to the image, e.g.:smile: :smile: is <img src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f604.png" height="20" width="20" align="absmiddle"> ?

(I'll also note that there are emoji plugins for jekyll if you want everyone to be able to use emojis seamlessly in their blogposts... :grin: )

MilesMcBain commented 7 years ago

Right so it would become: <img src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f680.png" height="20" width="20" align="absmiddle"> I'll make a commit.

MilesMcBain commented 7 years ago

Rocket image looked good on my local preview.

stefaniebutland commented 7 years ago

@jeroen Can you please make this post dated Wed July 5, 2017 live ... at your timezone convenience? When posted, please ping me on slack and I'll tweet it.

Thank you @MilesMcBain and @AliciaSchep !!!

AliciaSchep commented 7 years ago

thanks @MilesMcBain! I also had included two other emojis in as well, any chance you could either add the link to those or just remove? there was a :smile: and a :tada:. (Or is there a way I can edit the pull request? Happy to make the change myself, but I think I may need access to your fork of this repo)

MilesMcBain commented 7 years ago

I'm hesitant to include fixed size images into the middle of the text, wrapping weirdness etc? Could replace :smile: with lofi acsii version? :Tada: might have to go.

AliciaSchep commented 7 years ago

Good point @MilesMcBain! I removed or ascii-ified the in text ones.

jeroen commented 7 years ago

This is now live @stefaniebutland