search

ropensci / roweb

:no_entry: [DEPRECATED] Active at https://github.com/ropensci/roweb2
https://legacy.ropensci.org
Other
18 stars 29 forks source link

adds emldown post #325

Closed maelle closed 7 years ago

maelle commented 7 years ago

As planned, emldown unconf blog post for August the 1st.

maelle commented 7 years ago

Note: I can only make changes until Thursday evening (8pm CEST), after that I'm off for a long week-end.

maelle commented 7 years ago

Thanks a lot for your feedback @stefaniebutland!

maelle commented 7 years ago

Thanks for your useful feedback @sckott @karthik ! I hope I haven't missed anything. I can do changes myself until today 11am Pacific time.

karawoo commented 7 years ago

If there's anything else after @maelle goes offline I can take over.

karawoo commented 7 years ago

Though I don't have push access to her fork, so might require some extra git finagling.

maelle commented 7 years ago

Added you as collaborator does it give you push access?

karawoo commented 7 years ago

Yup 👍

karawoo commented 7 years ago

I've added a little bit to the beginning of the post to try to give more context about EML and why it's useful. Though now it takes a bit longer before we get to emldown, which is the main topic of the post. Let me know if you have any feedback or want additional changes.

karthik commented 7 years ago

@karawoo The post looks great and ready to merge. One small edit (which I am also happy to do post merge if you just want to enjoy your weekend) is to remove the ellipsis at the end of After installing the package from Github, you can apply it to your EML...

karawoo commented 7 years ago

I can make that edit, should the ellipsis be replaced with anything else since the sentence continues after the code chunk?

karthik commented 7 years ago

@karawoo Ah, never mind. I didn't notice that. PR accepted! Thanks Kara and Maelle! 💯

maelle commented 7 years ago

Thanks rOpenSci team and thanks @karawoo for handling this!