Closed mpadge closed 6 years ago
Please ping Scott and me here and/or on Slack later when you're ready for feedback.
One pre-emptive Q: Length? I'm thinking of cutting most of the messy code in the current, penultimate "visualisation" bit, and replacing it with a few descriptive lines. That'd make the whole thing quite short. I'm suspecting short is likely not a bad thing - avoids reader tune-out and all - but could readily extend with some more flowery prose if a bit more length was preferred. Brief thoughts @stefaniebutland @sckott?
(And @stefaniebutland: My delay in doing this was coz of waiting for the CRANification of dodgr
, which only appeared today! :champagne: helps write a much better post, methinks.)
ROpenSci
to rOpenSci
@mpadge I know this is a draft but since you opened the door ;-) I have comments that I hope are helpful
Thanks a heap for doing this! Hope it gets more eyes on your work.
okay @stefaniebutland @sckott, this should now be in a fairly decent form. Any and all feedback welcome - please be as critical as you want! Stefanie, I've replaced the gender analysis with a more generic "member/non-member" distinction. Funny thing was I had thought the gender one would have worked out the opposite way, and had what I thought was a rather funny yet totally PC claim about gender differences to interpret it. It didn't work out that way, and so I couldn't, and as you are well aware, it's ultimately better just to leave such prickly issues alone.
But now note that I've not really done any interpretation of the results at all. I could add a bit extra, but it's likely to be so highly speculative using these data alone that i doubt it would bring much. I've left it in the current form in the conviction that it's okay in a blog entry merely to show the kind of results that can be extracted, and to leave actual interpretation for other times/people/fora. If either of you disagree, I'd be totally happy to add a bit more exploratory code.
Also note that the figure links haven't yet been updated/set appropriately - i think you just need to uncomment the proper links once the post has been moved to the _posts
folder, but have left that up to you.
Thank you @mpadge ! I'll have another look early next week (or sooner depending in my to-do list)
@mpadge ok, I'm much later than I thought/ hoped. I'll look at this Mon 16th AM, Pacific time. Sorry for the delay
no worries - i'll have some time later on (my) tonight, which'll be your late afternoon, in case you desire any particular changes. An alternative would be for you to accept the PR, the re-commit any editorial interventions you see fit, and I can simply approve (or not, but hopefully that wouldn't be necessary).
@mpadge This post reads beautifully!!! With these revisions you make your case very well for people to use and contributing to the pkg. Once the post is up I'll send a handful of tweets from rOpenSci, so please RT etc from there. R-weekly picks up our posts & tweets very quickly (which is awesome) but of course we prefer to have the traffic go our way.
Pinging @sckott here to check for any technical issues.
Blog post? - yep
whoops, haven't got a link yet, but will do that. Don't accept the PR yet - I just wanted to let you know I'm fully onto it and all over it