ropensci / roweb3

rOpenSci website source
https://ropensci.org
20 stars 54 forks source link

add zoom link to and event #173

Closed stefaniebutland closed 3 years ago

stefaniebutland commented 3 years ago

Now that some of our events will be on zoom, such as labelathons, can an Event's deets act like a Comm Call deets to show zoom details when user clicks "Join the event/call"?

Challenge? I don't want it to interfere with non-rOpenSci events where deets shows "Practical information" heading. IMO that info, like a link to an R-Ladies meetup, could go outside the YAML in free text.

See this draft PR for Apr 29 Labelathon: PR; Preview

Can it say "Join the event"? not "Join the call"? If it's cleaner, both comm calls and other events could say "Join the event".

image

maelle commented 3 years ago

Comm call https://deploy-preview-172--ropensci.netlify.app/commcalls/may2021-r-universe/ Event with zoom https://deploy-preview-172--ropensci.netlify.app/events/labelathon01/ Event without zoom but some other deets https://deploy-preview-172--ropensci.netlify.app/events/2021-07-05-user2021/ Is it ok?

stefaniebutland commented 3 years ago

Comm call deploy-preview-172--ropensci.netlify.app/commcalls/may2021-r-universe

✅ perfect thank you

Event with zoom deploy-preview-172--ropensci.netlify.app/events/labelathon01

I would prefer this zoom mtg code info not be displayed, other than from "join the event". The comm call display is ideal for an event with zoom. Is it possible for "Practical information" heading and deets content to not be displayed for any event (with or without zoom)?

Screen Shot 2021-04-02 at 10 08 35 AM

Event without zoom but some other deets deploy-preview-172--ropensci.netlify.app/events/2021-07-05-user2021

✅ Aha - when I saw "join the event" I was wondering what it would say here. Good solution.

Screen Shot 2021-04-02 at 10 21 15 AM

Question

maelle commented 3 years ago

Happy to implement any further feedback.

stefaniebutland commented 3 years ago

Thank you. Looks great