search

ropensci / roweb3

rOpenSci website source
https://ropensci.org
20 stars 52 forks source link

No alt text on photo galleries #666

Open steffilazerte opened 10 months ago

steffilazerte commented 10 months ago

The photo galleries don't have the alt text (as far as I can tell using right-click Inspect Accessibility Properties).

For example: https://ropensci.org/blog/2023/02/27/runiverse-discovering/ Code with alt: https://github.com/ropensci/roweb3/blob/3764b0a1b7752e3f3c3bbf68119f75c66fe868af/content/blog/2023-02-27-runiverse-discovering/index.md?plain=1#L40

maelle commented 10 months ago

Oh right, they're in the source HTML, but they're greyed out when I look at the web developer console.

image

maelle commented 10 months ago

Adding the alt text doesn't look straightforward https://photoswipe.com/caption/

maelle commented 10 months ago

@jeroen does https://photoswipe.com/caption/ make sense to you, i.e., would you know how to edit the changes added in https://github.com/ropensci/roweb3/pull/487/files so that photo galleries feature alternative text?

maelle commented 3 months ago

@jeroen friendly reminder in case you have time

jeroen commented 3 weeks ago

I think they are actually there where a screenreader can find them. Try running this in the chrome devtools:

$('figure img').map((x,y) => console.log(y))

Perhaps they get grayed out when the lightbox is opened, but this won't affect a screenreader because the screenreader should not interact with the lightbox. It just reads the page as is.

yabellini commented 2 weeks ago

After checking with a screen reader user in two different browsers, the screen reader does not find the alt-text. See https://github.com/ropensci-org/blog-guidance/pull/216 for the details.