Source hardcoded to NPN

[Peter9192]

I'm trying to download data using rppo, but I found I can only get results from USA-NPN. It looks like that source is hardcoded here:

https://github.com/ropensci/rppo/blob/f6d0c203bc4ef46c2c6525ad086956a770d98bde/R/ppo_data.R#L130

Would it be possible to remove this line so we can get all sources, or perhaps make it configurable to the user? I'd be happy to open a PR if you let me know what option you prefer.

[jdeck88]

thanks... can you do a PR? John

On Fri, Feb 17, 2023 at 8:46 AM Peter Kalverla @.***> wrote:

I'm trying to download data using rppo, but I found I can only get results from USA-NPN. It looks like that source is hardcoded here:

https://github.com/ropensci/rppo/blob/f6d0c203bc4ef46c2c6525ad086956a770d98bde/R/ppo_data.R#L130

Would it be possible to remove this line so we can get all sources, or perhaps make it configurable to the user? I'd be happy to open a PR if you let me know what option you prefer.

— Reply to this email directly, view it on GitHub https://github.com/ropensci/rppo/issues/18, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZ3RPZYWLCUKPIIXXQBJ3WX5XIXANCNFSM6AAAAAAU7MN2A4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- John Deck (541) 914-4739

[jdeck88]

Also, i see that the automated R-CMD checks are failing on me accepting two recent PRs, can you check on that before submitting the next PR? I don't have time to look into this for the next week or so since i'm travelling but happy to accept your PRs to get it working for you