Don't short-circuit in checking return code

ropensci / rppo

R package for accessing PPO data store

https://docs.ropensci.org/rppo

BSD 3-Clause "New" or "Revised" License

3 stars 5 forks source link

Don't short-circuit in checking return code #22

Open Peter9192 opened 8 months ago

Peter9192 commented 8 months ago

I noticed that when I made a query that warned me about "no results found", the response was still filled with data from a previous query.

This is because, in checking the result, the first condition was true and the short-circuit evaluation thus proceeded with the else branch without checking the second condition.

Instead, it should return empty when

no result
yes result, but the status code is wrong

Also updates the URL to NPN servers

Peter9192 commented 8 months ago

Checks fail on unrelated server issues.

Peter9192 commented 8 months ago

Checks fail on unrelated server issues.

Looks like it could be related to https://github.com/usa-npn/rnpn/issues/33

Peter9192 commented 8 months ago

Not sure why there are two failing tests now, they run fine on my end.