search

ropensci / ruODK

ruODK: An R Client for the ODK Central API
https://docs.ropensci.org/ruODK/
GNU General Public License v3.0
41 stars 12 forks source link

Incorrect pull in of review state #138

Closed HeatherMM1321 closed 2 years ago

HeatherMM1321 commented 2 years ago

Problem

Review state is being pulled in by the submission_list() function as a datetime.

ruODK function(s) used

submission_list()

Unexpected behaviour

In the code for submission_list() (line 99), it is set to mutate anything containing "at" as a datetime. However, the review state column is now labeled as "review_state" meaning that it gets incorrectly caught by this. I believe this could be fixed by simply changing this line of code to say contians("_at")

florianm commented 2 years ago

Thanks for reporting this and suggesting a fix, too! I'll push the fix later today.

florianm commented 2 years ago

@HeatherMM1321 this is fixed in v1.3.11, feel free to test!