ropensci / ruODK

ruODK: An R Client for the ODK Central API
https://docs.ropensci.org/ruODK/
GNU General Public License v3.0
42 stars 13 forks source link

Documentation for attachment_link #57

Closed florianm closed 4 years ago

florianm commented 4 years ago

Feature

Source https://github.com/ropensci/software-review/issues/335#issuecomment-596120460

I also noticed that attachment_link appears to be a place holder for functionality you intend to bring up in the future. It isn't demonstrated in the vignettes, and it has a TODO note in it that indicates that you will be improving this function to use the form schema to find attachment fields, like you did for ru_datatime. I am not sure the best approach here, but I think it's worth considering putting this in a development branch for now if it is not fully implemented. I might be wrong about your intentions here, so pardon me if that is the case. Would it make sense to do what this function does when a user calls handle_ru_attachments?

florianm commented 4 years ago

The TODO note refers to the intent to introspect the form_schema to find column names of attachment files. This is now implemented as follows:

attachment_link usage is (still) demonstrated in examples and (updated) in vignette "restful-api" under "submission_export".