ropensci / rzmq

R package for ZMQ
https://docs.ropensci.org/rzmq
84 stars 30 forks source link

Add receive.multipart and send.multipart functions #6

Closed takluyver closed 10 years ago

takluyver commented 10 years ago

Hi, I'm using rzmq to write an R kernel for IPython. I wrote these functions as part of the kernel, but I think they belong in rzmq. It may be more efficient to implement them in C++, but I'm even less familiar with C++ than R.

I find the API somewhat confusing - there are several receive.* functions without send counterparts, I'm not sure if receive.string and send.raw.string are counterparts or not, and the serialize/unserialize parameters to receive.socket and send.socket seem to make the other send/receive methods unnecessary. For my purposes, I serialise the data as JSON before using rzmq, so I'm only interested in sending and receiving bytes/strings, but I'm happy to make the API more flexible if that makes sense.

takluyver commented 10 years ago

Now I'm a bit more familiar with the structure of R packages, I've added the necessary documentation and exports for these functions. R CMD check also turned up a mistake in another doc file, which I fixed.

Any chance of getting this merged in the next few days? I'm going to be taking the IPython R kernel to a hackathon Karthik's hosting next week, and it would be good to move these functions out of my code before then.

takluyver commented 10 years ago

Thanks! Do you think you'll have time to put a new release on CRAN soon? Is there anything I can help with to bring that about?

armstrtw commented 10 years ago

I'm on vacation right now, but I should be able to put it up when I get back (on April 1st or so).

takluyver commented 10 years ago

Great, thanks. Enjoy your vacation!