search

ropensci / skimr

A frictionless, pipeable approach to dealing with summary statistics
https://docs.ropensci.org/skimr
1.11k stars 79 forks source link

Crayon tibble issue where table bodies are blank #569

Closed elinw closed 4 years ago

elinw commented 4 years ago

On a number of platforms in version 2 the bodies of the skimr tables that display when printing are empty. We have been advising people to manually set options(crayon.enabled = FALSE). This is both awkward and can have side effects. This PR follows the model here https://github.com/r-lib/crayon/issues/83#issuecomment-473428346

elinw commented 4 years ago

@michaelquinn32

codecov-io commented 4 years ago

Codecov Report

Merging #569 into develop will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #569      +/-   ##
===========================================
+ Coverage    96.07%   96.08%   +0.01%     
===========================================
  Files           13       13              
  Lines          560      562       +2     
===========================================
+ Hits           538      540       +2     
  Misses          22       22
Impacted Files Coverage Δ
R/skim_print.R 96.66% <100%> (+0.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e8f235...9fb7988. Read the comment docs.

michaelquinn32 commented 4 years ago

That would also work later, where we need to check if crayon is enabled for the strip step.

elinw commented 4 years ago

It actually doesn't seem to work there ... at least when I tried it.

michaelquinn32 commented 4 years ago

Thanks for the patience on this!