search

ropensci / skimr

A frictionless, pipeable approach to dealing with summary statistics
https://docs.ropensci.org/skimr
1.11k stars 79 forks source link

Adds support for predicates (Issue #611) #612

Closed bastiantorges closed 3 years ago

bastiantorges commented 4 years ago

I gave fixing #611 a try. As predicates were introduced in tidyselect 1.0 this changes the required tidyselect version.

elinw commented 4 years ago

Thanks!

The question I have is whether we test for version of tidyselect or if we force everyone to update. The tidyverse updates break a lot of things, and I'd prefer that skimr remain usable for users who can't update for that reason.

michaelquinn32 commented 4 years ago

LGTM.

I'm fine with the version bump. I think it's preferable to a version-based check on the behavior of the package. I realize that this puts some overhead on users, but everyone will have to update eventually.

michaelquinn32 commented 4 years ago

Thanks for taking care of this!

elinw commented 4 years ago

Thinking about it I'm basically sure that one way or another probably the dplyr and other updates have essentially forced a lot of other minimum versions.

@brodz Do you want to add yourself as a contributor in the Description file?

bastiantorges commented 4 years ago

@elinw I added myself as a contributor.