Closed rsaporta closed 3 years ago
Thank you for this, I think it makes a lot of sense for us to support data.table cleanly.
@rsaporta Are you able to do the requested changes? Also you can add yourself as a contributor in the DESCRIPTION file.
Do we really need to export dt_key()
?
@rsaporta Are you able to update your branch? Or would you rather have us take care of it?
I'm closing this in favor of https://github.com/ropensci/skimr/pull/633 ... I'm still not sure if we need the @export.
Making skimr data.table aware
Summary
dtplyr
is loaded (closes #621 )Details:
1. include key in output
data
is adata.table
summary_df will include thekey
, defaulting toNULL
if nokey
is set (this latter part matches the output ofdata.table::key(data)
data
is not adata.table
, there is no change tosummary_df
data
was adata.table
and converted to eitherdata.frame
ortibble
, then behavior of skimr is unchanged. (several test outputs added to confirm)2. no pesky warnings when
dtplyr
is loadedskim_by_type.data.table
tests: