ropensci / skimr

A frictionless, pipeable approach to dealing with summary statistics
https://docs.ropensci.org/skimr
1.11k stars 79 forks source link

data.table aware #622

Closed rsaporta closed 3 years ago

rsaporta commented 3 years ago

Making skimr data.table aware

Summary

  1. include key in output
  2. no pesky warnings when dtplyr is loaded (closes #621 )

Details:

1. include key in output

2. no pesky warnings when dtplyr is loaded

tests:

elinw commented 3 years ago

Thank you for this, I think it makes a lot of sense for us to support data.table cleanly.

elinw commented 3 years ago

@rsaporta Are you able to do the requested changes? Also you can add yourself as a contributor in the DESCRIPTION file.

elinw commented 3 years ago

Do we really need to export dt_key()?

elinw commented 3 years ago

@rsaporta Are you able to update your branch? Or would you rather have us take care of it?

elinw commented 3 years ago

I'm closing this in favor of https://github.com/ropensci/skimr/pull/633 ... I'm still not sure if we need the @export.