search

ropensci / skimr

A frictionless, pipeable approach to dealing with summary statistics
https://docs.ropensci.org/skimr
1.1k stars 79 forks source link

Add list as a class to skim_list objects. #693

Closed elinw closed 2 years ago

elinw commented 2 years ago

@michaelquinn32 I did this for a reason that I don't remember (it must have popped up as an issue when I was doing something), but it makes sense to me to add "list" in a second slot for the "skim_list" objects. But I don't see any problem with making tis change

elinw commented 2 years ago

I think it had to do with the issue about writing to xlsx, which for sure works better with a list. But it's also good to do this anyway because then any function that applies to lists can be used.

elinw commented 2 years ago

@michaelquinn32 Are you okay with this?

michaelquinn32 commented 2 years ago

Thanks for taking care of this.