search

ropensci / skimr

A frictionless, pipeable approach to dealing with summary statistics
https://docs.ropensci.org/skimr
1.11k stars 78 forks source link

Issues with 4.2 #702

Closed elinw closed 1 year ago

elinw commented 2 years ago

So it looks like the switch from a warning to error for if() of objects of length 1 revealed that we had a hidden warning. This becoming an error then led to cascading other problems. For reasons I'm not sure of there was also a problem with finding reassign_skim_attributes. All this is why the original issue of pkgdown not building arose.

michaelquinn32 commented 2 years ago

I just checked this against the current develop branch (after merging in all changes for the next version)

devtools::check(env_vars = c("_R_CHECK_LENGTH_1_CONDITION_" = "true"))

Once the fix for #700 is in, can you let me know if this is still an issue? Thanks!

elinw commented 1 year ago

I think we're good!