search

ropensci / skimr

A frictionless, pipeable approach to dealing with summary statistics
https://docs.ropensci.org/skimr
1.12k stars 79 forks source link

Fixes for dev tidyselect #713

Closed hadley closed 2 years ago

hadley commented 2 years ago

We're now being a little stricter with inputs.

michaelquinn32 commented 2 years ago

Thanks Hadley! Would you mind taking a look at the vignette too? That seems to be the source of the error in the checks.

hadley commented 2 years ago

Unfortunately I don't seem able to reproduce that locally.

hadley commented 2 years ago

Hmmm, works on oldrel-1 and fails on latest. I think this is what forces me to update R 😶

hadley commented 2 years ago

Ok, on 4.2 and can reproduce 😄

hadley commented 2 years ago

Took me a while to get to the root cause which was using dplyr::groups() instead of dplyr::group_vars() — groups() returns a list of symbols, which in many cases in R 4.1 or old tidyselect would automatically get coerced to a character vector.

I also updated the docs to latest roxygen, updated the build script, and fixed another issue revealed by 4.2's check.

michaelquinn32 commented 2 years ago

Oh man, didn't realize it was that big of a change.

Thank you so much!