Fixes for dev purrr - Githubissues

ropensci / skimr

A frictionless, pipeable approach to dealing with summary statistics

https://docs.ropensci.org/skimr

1.11k stars 78 forks source link

Fixes for dev purrr #716

Closed hadley closed 1 year ago

hadley commented 1 year ago

The root cause of the problem is that list_modify(x, y = NULL) now returns list(y = NULL) rather than removing y as previously. So I made two changes:

merge_skimmers() removes the NULL skimmers after merging
I don't know why get_local_skimmers() broke but once I figured out what it was doing, I rewrote it from first principles and it now works.

(Also includes some remaining tidyselect tweaks to avoid warnings in the tests)

michaelquinn32 commented 1 year ago

Awesome. Thanks Hadley!

hadley commented 1 year ago

FYI purrr is now scheduled for release to CRAN on Dec 19