search

ropensci / skimr

A frictionless, pipeable approach to dealing with summary statistics
https://docs.ropensci.org/skimr
1.1k stars 78 forks source link

Stop skipping tests on windows #729

Closed michaelquinn32 closed 1 year ago

michaelquinn32 commented 1 year ago

With the release of R 4.2.2, we shouldn't need this fallback anymore. https://blog.r-project.org/2022/06/16/upcoming-changes-in-r-4.2.1-on-windows/

We can hold off merging this until a later version of skimr.

Fixes #727

elinw commented 1 year ago

Yes I think we should do this for the next release and decide about whether we should change the minimum version of R or do something else. That said, CRAN only tests back to 4.1.2 at this point so the tests will pass there. The question is do we have users on old versions and is the infrastructure we have sufficient for them. (Because then we can not raise the minimum.)

Raising the minimum would get us native pipes would would likely improve performance, so that's something to consider also. My experience is that you have convert carefully because there are things that magrittr works for that the native pipe does not.