search

ropensci / skimr

A frictionless, pipeable approach to dealing with summary statistics
https://docs.ropensci.org/skimr
1.1k stars 78 forks source link

Haven #740

Open michaelquinn32 opened 8 months ago

michaelquinn32 commented 8 months ago

Fixes #737

While haven is suggested, we will see errors if it is not also loaded when skimming over labeled vectors.

elinw commented 8 months ago

@michaelquinn32 Do you there should be a message or warning?

michaelquinn32 commented 8 months ago

Thanks for the suggestion, but I don't think we need any more warnings. This pattern is pretty standard for managing suggested dependencies. The biggest problem is that it wasn't loaded when needed.

If the load fails we can surface an error. Here are some examples: https://github.com/search?q=org%3Atidyverse%20requireNamespace&type=code