ropensci / slopes

Package to calculate slopes of roads, rivers and trajectories
https://docs.ropensci.org/slopes/
GNU General Public License v3.0
70 stars 6 forks source link

Functions to calculate Z_Min, Z_Max, Z_Mean #19

Closed Robinlovelace closed 3 years ago

Robinlovelace commented 3 years ago

From #10

temospena commented 3 years ago

hey @Robinlovelace , just added the z_mean, z_maxand z_minfunctions. https://github.com/ITSLeeds/slopes/commit/6b93aaa2c277cacc69cf77027ff45ac9103b25db z_direction still missing (related to #20)

I'm not sure about @rdname s, can you please check?

Robinlovelace commented 3 years ago

Great work @temospena ! Will take a look now.

Robinlovelace commented 3 years ago

I'm not sure about @rdname s, can you please check?

Just checked and updated in https://github.com/ITSLeeds/slopes/commit/9f4769453bbc9adda98eefe49ff9e8ab74a41d48

Basically @rdname is used to make one help page (slope_z_value in this case) be used by many functions. It's good if functions are very similar as is the case here and is a bit lazy because it means less typing of documentation code... Looking good!