ropensci / slopes

Package to calculate slopes of roads, rivers and trajectories
https://docs.ropensci.org/slopes/
GNU General Public License v3.0
70 stars 6 forks source link

Documents #38

Closed temospena closed 3 years ago

temospena commented 3 years ago

I reorganized the README + Get Started + Intro to slopes (needed to move this one out of get started).

I am not happy with the Examples section in Get Started (slopes.Rmd and also some in README.Rmd), in particular with the slopes_ functions.

temospena commented 3 years ago

It threw an error related with slopes.Rmd vignette (Get Started)

 Error: processing vignette 'slopes.Rmd' failed with diagnostics:
  there is no package called 'tmap'
  --- failed re-building 'slopes.Rmd'

  --- re-building 'verification.Rmd' using rmarkdown
  --- finished re-building 'verification.Rmd'

  SUMMARY: processing the following file failed:
    'slopes.Rmd'

  Error: Vignette re-building failed.
  Execution halted
Robinlovelace commented 3 years ago

Looking great :tada: I agree about renaming the example to lisbon_route_network and agree re GPS data, we could generate a route.

Regarding GitHub Actions this might fix it but not sure, hope so! https://github.com/ITSLeeds/slopes/pull/39

temospena commented 3 years ago

I think it is ready for your review. In particular the examples - which I had a different story line.

We should clarify the slopes_ functions:

temospena commented 3 years ago

d903043cdb076b99e1b82f8fb540689901552397

Robinlovelace commented 3 years ago

:+1: