Closed temospena closed 3 years ago
It threw an error related with slopes.Rmd
vignette (Get Started)
Error: processing vignette 'slopes.Rmd' failed with diagnostics:
there is no package called 'tmap'
--- failed re-building 'slopes.Rmd'
--- re-building 'verification.Rmd' using rmarkdown
--- finished re-building 'verification.Rmd'
SUMMARY: processing the following file failed:
'slopes.Rmd'
Error: Vignette re-building failed.
Execution halted
Looking great :tada: I agree about renaming the example to lisbon_route_network
and agree re GPS data, we could generate a route.
Regarding GitHub Actions this might fix it but not sure, hope so! https://github.com/ITSLeeds/slopes/pull/39
I think it is ready for your review. In particular the examples - which I had a different story line.
We should clarify the slopes_
functions:
d903043cdb076b99e1b82f8fb540689901552397
:+1:
I reorganized the README + Get Started + Intro to slopes (needed to move this one out of get started).
I am not happy with the Examples section in Get Started (slopes.Rmd and also some in README.Rmd), in particular with the
slopes_
functions.cyclestreets_route
can be used for this example.lisbon_route_segments
shouln't be renamed tolisbon_route_netw
, because the singular/plural sometimes is confusing.