ropensci / software-review-meta

For organizing projects related to rOpenSci Software Peer Review
10 stars 3 forks source link

Specify conditions for Windows CI #48

Closed noamross closed 6 years ago

noamross commented 6 years ago

We should specify that Windows/AppVeyor CI is required in certain situations:

Anything else?

I wonder if we can auto-detect system calls and check for Appveyor CI through a goodpractice check, (See https://github.com/MangoTheCat/goodpractice/issues/86, @annakrystalli)

It's probably too new, but do we think we would move to recommending sys for better cross-platform system calls? @jeroen

maelle commented 6 years ago
cboettig commented 6 years ago

Anything with file system / path calls(?) On Sun, Apr 15, 2018 at 7:53 AM Maëlle Salmon notifications@github.com wrote:

  • Authors with accented names 😜 More generally/seriously, text with accents because of possible encoding issues. Not sure CI would help seeing text gets messy though.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ropensci/onboarding-meta/issues/48#issuecomment-381412492, or mute the thread https://github.com/notifications/unsubscribe-auth/AANlegG-FgwwLwXz0Q5qCvFxFbQ_9GbLks5to17rgaJpZM4TVf8z .

--

http://carlboettiger.info

maelle commented 6 years ago

I used the current list in the packaging bookdown.

maelle commented 6 years ago

I summarized all points in https://ropensci.github.io/dev_guide/ci.html#whichci

Further discussion welcome in https://github.com/ropensci/dev_guide