ropensci / software-review

rOpenSci Software Peer Review.
291 stars 104 forks source link

patentsview #112

Closed crew102 closed 7 years ago

crew102 commented 7 years ago

Summary

This package provides a wrapper around the patentsview api, which serves USPTO patent data that has been disambiguated. There is one main function to search and download data from the API (search_pv) and several other helper functions.

Package: patentsview
Type: Package
Title: An R Client to the PatentsView API
Version: 0.1.0.9000
Authors@R: person("Christopher", "Baker", email = "chriscrewbaker@gmail.com",
    role = c("aut", "cre"))
Encoding: UTF-8
Description: Provides functions to simplify the PatentsView API
    (http://www.patentsview.org/api/doc.html) query language,
    send GET and POST requests to the API's seven endpoints, and parse the data
    that comes back.
URL: https://github.com/crew102/patentsview
BugReports: https://github.com/crew102/patentsview/issues
License: GPL-2
LazyData: TRUE
Depends:
    R (>= 3.1)
Imports:
    httr,
    jsonlite,
    utils
Suggests:
    knitr,
    rmarkdown,
    testthat
VignetteBuilder: knitr
RoxygenNote: 6.0.1

Requirements

Confirm each of the following by checking the box. This package:

Publication options

Detail

R CMD check passes with one warning regarding this being my first package submission.

I believe the package follows the guidelines, but there are a few items I would like to highlight. These may or may not be issues:

  1. The README does not follow the exact same format as described in the packaging guidelines.
  2. I have added a cran-comment.md file which I plan on updating before submitting to CRAN.
  3. I have not tagged the git repo yet, as I would like to wait for feedback before considering this version complete.
crew102 commented 7 years ago

No problem - I thought the process was well done. I'm changing the urls now and will open a pr to integrate those into ropensci/patentsview. I'm also changing the badge urls for travis and appveyor.

maelle commented 7 years ago

Cool!

The repo was activated on Travis and I think on Appveyor for which the badges will be [![Build status](https://ci.appveyor.com/api/projects/status/ri4lrakyrw2117mi?svg=true)](https://ci.appveyor.com/project/ropensci/patentsview)

No need for a PR, you can commit and push directly well unless you prefer doing it with a branch.

maelle commented 7 years ago

We can discuss further in the thread but I'll close this now.

Thanks @crew102 for your work, and @expectopatronum & @poldham for your reviews!

crew102 commented 7 years ago

Sounds good..I did a PR but I'll probably just push directly to ropensci/patentsview master in the future. Thanks again for your help.

maelle commented 7 years ago

I'd like to tweet about the package, are you on Twitter?

crew102 commented 7 years ago

I'm not on twitter but a tweet would be nice!

maelle commented 7 years ago

https://twitter.com/ma_salmon/status/876822469843267584 :white_check_mark:

crew102 commented 7 years ago

Hi @maelle , is it ok if I submit patentsview to CRAN without the ropensci footer in the readme? I'm getting this warning when I build on winbuilder (which I assume will be a showstopper for CRAN admins):

checking top-level files ... WARNING
Conversion of 'README.md' failed:
pandoc.exe: Could not fetch http://ropensci.org/public_images/github_footer.png
TlsExceptionHostPort (HandshakeFailed Error_EOF) "ropensci.org" 80
maelle commented 7 years ago

@crew102 yes with that Pandoc bug the best is to remove it before CRAN submission and then put it back afterwards. Hopefully that bug will be resolved soon.

Would you be interested in writing a blog post about patentsview for rOpenSci blog?

crew102 commented 7 years ago

Sure, I could do a post. I'd like to submit to CRAN first. I'll let you know when that process is over. Are there any guidelines/suggestions for writing the blog posts?

maelle commented 7 years ago

Awesome! I'll let @stefaniebutland take over reg. the blog post (she's rOpenSci community manager), she'll be able to tell you more regarding timing & content of the blog post.

In any case I look forward to reading it!

Good luck with the CRAN submission, don't hesitate to ask any question if needed.

crew102 commented 7 years ago

Thanks a lot!