Closed azizka closed 6 years ago
Thanks @isteves! No, I just need to run the last checks which I'll do ASAP!
Approved! Thanks @azizka for submitting and @isteves @Pakillo for your reviews! 😺
To-dos:
[![ropensci_footer](https://ropensci.org/public_images/ropensci_footer.png)](https://ropensci.org)
"[![AppVeyor Build Status](https://ci.appveyor.com/api/projects/status/github/ropensci/pkgname?branch=master&svg=true)](https://ci.appveyor.com/project/individualaccount/pkgname)
."rev"
-type contributors in the Authors@R
field (with their consent). More info on this here.Welcome aboard! We'd also love a blog post about your package, either a short-form intro to it (https://ropensci.org/tech-notes/) or long-form post with more narrative about its development. (https://ropensci.org/blog/). If you are interested, @stefaniebutland will be in touch about content and timing.
We've started putting together a gitbook with our best practice and tips, this chapter starts the 3d section that's about guidance for after onboarding. Please tell us what could be improved, the corresponding repo is here.
Hej,
great, thanks. Very exciting. I am teaching abroad with no opportunity to work on this the next two weeks, but will do this as soon as I come back!
Thanks again to all of you!
Hi, @isteves, @Pakillo, @maelle do you agree to be acknowledged as reviewers for the package? Please let me know here.
@maelle, after transferring ownership, how can I edit the short package description on the github page, since it links to the old pagedown, adress?
@azizka I've now made you admin of the repo again! I couldn't do that before transfer. Thanks for transferring! 😸
Hello @azizka. Congratulations on acceptance of CoordinateCleaner! Are you interested in writing a post for the rOpenSci blog, either a short-form intro to it (https://ropensci.org/tech-notes/) or long-form post with more narrative about its development (https://ropensci.org/blog/)?
This link will give you many examples of blog posts by authors of onboarded packages so you can get an idea of the style and length you prefer: https://ropensci.org/tags/onboarding/.
Here are some technical and editorial guidelines for contributing a post: https://github.com/ropensci/roweb2#contributing-a-blog-post.
Please let me know what you think.
Hi @stefaniebutland, yes I am interested in writing a blog post, but there is a manuscript for the package in review at MEE currently, I'd prefer to wait for a decision on that first. Cheers,
Alex
Sounds good @azizka. Would be nice to be able to note the publication in the post.
Hej @maelle,
almost done, the last thing is to migrate the badges. Where can I find help to migrate the travis-ci build and codecov badges properly, since they are not working at the moment.
Thanks!
@azizka weird, I have now activated the repo at https://travis-ci.org/ropensci/CoordinateCleaner (your badge points to travis-ci.com at the moment), let's see if that works.
OK, thanks. I switch to travis.org; let's see if it works once the first run is done. I fixed the codecov badge.
Alright, I think everything is working now. The latest version (2.0-2) is also on CRAN now. Is there anything else to do?
No, sorry, closing the issue now!
@azizka I see your manuscript is submitted to MEE. Wishing you a smooth process
@azizka, Scott Chamberlain who is the rOpenSci point person for the MEE collaboration told me that the coordinatecleaner paper will be published on 21 Feb - and MEE asked if we can coordinate blog post timing.
This would be great to bring more attention to your work if we can coordinate. Do you think you could have a draft post submitted by Thurs Feb 14 or Fri 15th this week? That would give me time to review and you to address any feedback.
(edited). Update - I understand that you're also working on a post for MEE. Our audiences are different, but we can discuss options for cross-posting if you don't want to write two posts.
Summary
What does this package do? (explain in 50 words or less): Identify problematic records in large databases of biological and palaeontological collections, to improve data quality for analyses in biogeography, ecology and conservation.
Paste the full DESCRIPTION file inside a code block below:
URL for the package (the development repository, not a stylized html page): https://github.com/azizka/CoordinateCleaner
Please indicate which category or categories from our package fit policies this package falls under *and why(? (e.g., data retrieval, reproducibility. If you are unsure, we suggest you make a pre-submission inquiry.):
geospatial data, because the package deals with improving data quality of occurrence records of biological specimens
reproducible research, because the package replaces potentially badly documented ad-hoc decisions from GUI GIS with clearly defined functions
data munging, becasue the packages processes commonly used geospatial data (geographic coordinates)
Who is the target audience and what are scientific applications of this package? Anybody using geographic coordinates from biological collections on a large scale, thus mostly researchers in biogeography, (maco-)ecology, evolutionary biology and conservation practitioners
Are there other R packages that accomplish the same thing? If so, how does yours differ or meet our criteria for best-in-category? Yes, scrubr, see this pre-submission enquiry: https://github.com/ropensci/onboarding/issues/199
If you made a pre-submission enquiry, please paste the link to the corresponding issue, forum post, or other discussion, or @tag the editor you contacted. https://github.com/ropensci/onboarding/issues/199, @sckott
Requirements
Confirm each of the following by checking the box. This package:
Publication options
paper.md
matching JOSS's requirements with a high-level description in the package root or ininst/
.Detail
[x] Does
R CMD check
(ordevtools::check()
) succeed? Paste and describe any errors or warnings:[x] Does the package conform to rOpenSci packaging guidelines? Please describe any exceptions: Exceptions:
NEWS file - there is one now, but only started with the latest version.
Package name: Unfortunately, the name contains capital letters (CoordinateCleaner), but it is on CRAN already.
_Function naming: Functions for individual tests are snakecase and pipe compatible, wrapper function around all tests are CamelCase.
Documentation: not built with roxygen.
If this is a resubmission following rejection, please explain the change in circumstances: Nope
If possible, please provide recommendations of reviewers - those with experience with similar packages and/or likely users of your package - and their GitHub user names:
SaraVarela, sckott