ropensci / software-review

rOpenSci Software Peer Review.
291 stars 104 forks source link

taxlist, a package for structuring taxonomic lists and related information #233

Closed kamapu closed 3 years ago

kamapu commented 6 years ago

Summary

The taxlist package structures taxonomic information into S4 objects and implements methods for the manipulation of contained information. Such objects may or may not contain information on synonymy, taxonomic ranks, parent-child relations, taxon views (references used to establish relation between taxon usage names and taxon concepts), and taxon (functional) traits.

Package: taxlist
Version: 0.1.5
Encoding: UTF-8
Date: 2018-06-18
Title: Handling Taxonomic Lists
Authors@R:
    person("Miguel", "Alvarez", email="kamapu78@gmail.com", role=c("aut", "cre"))
Depends:
    R(>= 3.0.0),
    stats,
    utils
Imports:
    foreign,
    grDevices,
    methods,
    taxize,
    stringdist,
    vegdata
Suggests:
    ape,
    devtools,
    knitr,
    stringi,
    taxa,
    rmarkdown
LazyData: true
Description: Handling taxonomic lists through objects of class 'taxlist'.
    This package provides functions to import species lists from 'Turboveg'
    (<https://www.synbiosys.alterra.nl/turboveg>) and the possibility to create
    backups from resulting R-objects.
    Also quick displays are implemented as summary-methods.
License: GPL (>= 2)
URL:
    https://cran.r-project.org/package=taxlist,
    https://github.com/kamapu/taxlist
BugReports: https://github.com/kamapu/taxlist/issues
Collate:
    'NULLing.R''auxiliary_functions.R''deprecated-functions.R''dissect_name.R'
    'taxlist-class.R''clean.R''as.list.R''taxon_views.R''add_view.R'
    'taxon_names.R''taxon_relations.R''taxon_traits.R'
    'levels.R''add_concept.R''update_concept.R''add_synonym.R'
    'accepted_name.R''synonyms.R''basionym.R''update_name.R''delete_name.R'
    'replace_view.R''get_children.R'
    'change_concept.R''Extract.R''subset.R'
    'merge_taxa.R''backup_object.R''load_last.R''summary.R'
    'df2taxlist.R''tv2taxlist.R''tnrs.R''tax2traits.R''match_names.R''print_name.R'
    'StartMessage.R'
VignetteBuilder: knitr

https://github.com/kamapu/taxlist

Reproducibility, because this package makes taxonomic information available in a quasi-standard format and tests inconsistencies on the content of taxonomic lists.

In general to taxonomists and biodiversity scientists, in particular to vegetation ecologists (taxlist objects are implemented in the package vegtable).

While its functionality may overlap the package taxa, the package taxlist attempts to be flexible in the degree of completeness of data (incompleteness is very frequent in vegetation-plot databases), it is meant to be integrated in objects containing diversity information (as in the mentioned package vegtable) and to import data from local storage (spreadsheets, Turboveg data sets and even PostgreSQL tables by using vegtable2).

Requirements

Confirm each of the following by checking the box. This package:

Publication options

Detail

@arendsee @zachary-foster @sckott

mcsiple commented 3 years ago

Yes, it looks good to me. Thank you @kamapu , @levisc8 and @maelle (and congratulations from me too!)

On Thu, Sep 17, 2020 at 12:02 AM Maëlle Salmon notifications@github.com wrote:

Thanks @kamapu https://github.com/kamapu and congrats again on the new family member!

@mcsiple https://github.com/mcsiple @levisc8 https://github.com/levisc8 are you ok with the response?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ropensci/software-review/issues/233#issuecomment-694003511, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWM42UJRC6SOVICVT7MHM3SGGYB7ANCNFSM4FHQR3VQ .

--


Margaret (Megsie) Siple James S. McDonnell Postdoctoral Fellow Department of Ecology Evolution & Marine Biology University of California Santa Barbara

mobile: +1 (206) 661-8403

levisc8 commented 3 years ago

Hi @kamapu @mcsiple @maelle , Sorry for the slow response - the changes look good to me as well. Congratulations on the newest addition to your family @kamapu!

maelle commented 3 years ago

Approved! Thanks @kamapu for submitting and @mcsiple @levisc8 for your reviews! :smile_cat:

To-dos:

Should you want to acknowledge your reviewers in your package DESCRIPTION, you can do so by making them "rev"-type contributors in the Authors@R field (with their consent). More info on this here.

Welcome aboard! We'd love to host a post about your package - either a short introduction to it with an example for a technical audience or a longer post with some narrative about its development or something you learned, and an example of its use for a broader readership. If you are interested, consult the blog guide, and tag @stefaniebutland in your reply. She will get in touch about timing and can answer any questions.

We've put together an online book with our best practice and tips, this chapter starts the 3d section that's about guidance for after onboarding. Please tell us what could be improved, the corresponding repo is here.

kamapu commented 3 years ago

:partying_face: :partying_face: :partying_face: Then, there is some work to do, still. Surely I'll come back with some questions. Thanks to all participants in the development and review!

maelle commented 3 years ago

Please ping me once you've transferred the repo so that I might give you admin rights back, and feel free to ask me any question. Note that the invitation to the ropensci GitHub organization expires after I think one week. If you try to transfer the repo too late, tell me to re-send an invite.

kamapu commented 3 years ago

Transfer to ropensci

kamapu commented 3 years ago

@maelle I just transferred the repository to ROpenSci and tried to respond to all bullet points accordingly. There is just one issue regarding to the new package site and the images. How can I include the figures to be displayed in docs/ropensci?

maelle commented 3 years ago

@kamapu I gave you admin rights again. I am not sure I follow your question. Where are those images now? What docs/ropensci deploys is a pkgdown website. I see images in https://docs.ropensci.org/taxlist/, what is missing?

kamapu commented 3 years ago

@maelle In the source of the package there is a folder README-figures, which contains a PNG-image of the taxlist data schema (Figure before chapter Installing taxlist) but is also used to store figures generated by plotting functions (barplot at the very bottom, before Acknowledgements). While these figures are visible in https://github.com/ropensci/taxlist/, they are missing in https://docs.ropensci.org/taxlist/

maelle commented 3 years ago

Does https://pkgdown.r-lib.org/reference/build_home.html#images-and-figures help?

kamapu commented 3 years ago

Oh, yes! @maelle I used the opportunity to add some improvements:

maelle commented 3 years ago

Awesome! Let me plug two blog posts of mine :grin:

In any case I think I can close this issue but feel free to ask questions here / in the forum / etc.

Thanks all again!

kamapu commented 3 years ago

Thanks to everyone, also from my side. @maelle interesting posts. It seems to be, that my original idea of allocating data in a data package is not that bad at all... I wonder if this may be also a good practice for their use in examples within CRAN packages, assuming that the data-package may not be a CRAN-package...