Closed kamapu closed 3 years ago
Yes, it looks good to me. Thank you @kamapu , @levisc8 and @maelle (and congratulations from me too!)
On Thu, Sep 17, 2020 at 12:02 AM Maëlle Salmon notifications@github.com wrote:
Thanks @kamapu https://github.com/kamapu and congrats again on the new family member!
@mcsiple https://github.com/mcsiple @levisc8 https://github.com/levisc8 are you ok with the response?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ropensci/software-review/issues/233#issuecomment-694003511, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWM42UJRC6SOVICVT7MHM3SGGYB7ANCNFSM4FHQR3VQ .
--
Margaret (Megsie) Siple James S. McDonnell Postdoctoral Fellow Department of Ecology Evolution & Marine Biology University of California Santa Barbara
mobile: +1 (206) 661-8403
Hi @kamapu @mcsiple @maelle , Sorry for the slow response - the changes look good to me as well. Congratulations on the newest addition to your family @kamapu!
Approved! Thanks @kamapu for submitting and @mcsiple @levisc8 for your reviews! :smile_cat:
To-dos:
pkgdown
website and are ok relying only on rOpenSci central docs building and branding,
pkgdown
website with a redirecting pagehttps://docs.ropensci.org/package_name
URL
field alongside the link to the GitHub repository, e.g.: URL: https://docs.ropensci.org/foobar (website) https://github.com/ropensci/foobar
[![AppVeyor Build Status](https://ci.appveyor.com/api/projects/status/github/ropensci/pkgname?branch=master&svg=true)](https://ci.appveyor.com/project/individualaccount/pkgname)
.Should you want to acknowledge your reviewers in your package DESCRIPTION, you can do so by making them "rev"
-type contributors in the Authors@R
field (with their consent). More info on this here.
Welcome aboard! We'd love to host a post about your package - either a short introduction to it with an example for a technical audience or a longer post with some narrative about its development or something you learned, and an example of its use for a broader readership. If you are interested, consult the blog guide, and tag @stefaniebutland in your reply. She will get in touch about timing and can answer any questions.
We've put together an online book with our best practice and tips, this chapter starts the 3d section that's about guidance for after onboarding. Please tell us what could be improved, the corresponding repo is here.
:partying_face: :partying_face: :partying_face: Then, there is some work to do, still. Surely I'll come back with some questions. Thanks to all participants in the development and review!
Please ping me once you've transferred the repo so that I might give you admin rights back, and feel free to ask me any question. Note that the invitation to the ropensci GitHub organization expires after I think one week. If you try to transfer the repo too late, tell me to re-send an invite.
@maelle I just transferred the repository to ROpenSci and tried to respond to all bullet points accordingly. There is just one issue regarding to the new package site and the images. How can I include the figures to be displayed in docs/ropensci?
@kamapu I gave you admin rights again. I am not sure I follow your question. Where are those images now? What docs/ropensci deploys is a pkgdown website. I see images in https://docs.ropensci.org/taxlist/, what is missing?
@maelle
In the source of the package there is a folder README-figures, which contains a PNG-image of the taxlist
data schema (Figure before chapter Installing taxlist) but is also used to store figures generated by plotting functions (barplot at the very bottom, before Acknowledgements).
While these figures are visible in https://github.com/ropensci/taxlist/, they are missing in https://docs.ropensci.org/taxlist/
Oh, yes! @maelle I used the opportunity to add some improvements:
match_names()
is sorting results by similarityAwesome! Let me plug two blog posts of mine :grin:
In any case I think I can close this issue but feel free to ask questions here / in the forum / etc.
Thanks all again!
Thanks to everyone, also from my side. @maelle interesting posts. It seems to be, that my original idea of allocating data in a data package is not that bad at all... I wonder if this may be also a good practice for their use in examples within CRAN packages, assuming that the data-package may not be a CRAN-package...
Summary
The
taxlist
package structures taxonomic information into S4 objects and implements methods for the manipulation of contained information. Such objects may or may not contain information on synonymy, taxonomic ranks, parent-child relations, taxon views (references used to establish relation between taxon usage names and taxon concepts), and taxon (functional) traits.https://github.com/kamapu/taxlist
Reproducibility, because this package makes taxonomic information available in a quasi-standard format and tests inconsistencies on the content of taxonomic lists.
In general to taxonomists and biodiversity scientists, in particular to vegetation ecologists (
taxlist
objects are implemented in the package vegtable).While its functionality may overlap the package taxa, the package
taxlist
attempts to be flexible in the degree of completeness of data (incompleteness is very frequent in vegetation-plot databases), it is meant to be integrated in objects containing diversity information (as in the mentioned packagevegtable
) and to import data from local storage (spreadsheets, Turboveg data sets and even PostgreSQL tables by using vegtable2).Requirements
Confirm each of the following by checking the box. This package:
Publication options
paper.md
matching JOSS's requirements with a high-level description in the package root or ininst/
.Detail
[x] Does
R CMD check
(ordevtools::check()
) succeed? Paste and describe any errors or warnings:[x] Does the package conform to rOpenSci packaging guidelines? Please describe any exceptions:
If this is a resubmission following rejection, please explain the change in circumstances:
If possible, please provide recommendations of reviewers - those with experience with similar packages and/or likely users of your package - and their GitHub user names:
@arendsee @zachary-foster @sckott