Closed jackwasey closed 5 years ago
Thanks for your submission @jackwasey! 😀
We have two questions:
Thanks for getting back so quickly.
Thanks for your answers @jackwasey!
Your package seems in scope but it cannot be reviewed simultaneously at the two venues. It's up to you to have icd
reviewed first at JSS or here. Note that our reviews might result in request for changes, even for the stuff reviewed/requested by JSS. With that in mind, do you want to put this submission on hold?
Thank you - on hold sounds perfect, and I'll update when JSS complete.
Ok, thanks, good luck with the JSS submission!
If our reviews result in big changes, we have some guidance about that.
Thanks for creating such a great package!
However, I have a few questions that I would like to ask you about it. I am working with a data set that does not always have 5-digit ICD9 codes, and might have only a 3-digit code instead. For example, it has a code 250 for diabetes as opposed to 250.00 or 25000. So it does not recognize these 3-digit ICD9 codes. However, when I use the syntax explain_code, it correctly identifies the code. I have been using the syntax comorbid_ccs, I'm not sure where I am going wrong. I thought that the code would pick up codes that were 3-digit or without decimal points. Any advice would be greatly appreciated.
Thank you!
@rcih Could you please ask your question in the repo of the package i.e. https://github.com/jackwasey/icd/issues ? Thank you.
Yes, @rcih please head to https://github.com/jackwasey/icd/issues and give a reproducible example. Thanks!
Okay, will do @jackwasey. Thanks!
@jackwasey be aware that our policies https://ropensci.github.io/dev_guide/policies.html#review-process state that this issue will be closed after one year from applying the holding label (jul 2019) and you'll need to resubmit if the issue is closed
@jackwasey any update? Otherwise as per our policies mentioned above by @sckott, the issue will be closed because the submission has been on hold for more than one year.
It's been more than one year, so closing this.
Summary
Classifies medical diagnostic codes into disease comorbidity groups, calculates risk scores, and converts between types of ICD code, and decodes them to plain language.
https://github.com/jackwasey/icd
data munging: although data extraction is built in, the core functionality is the comorbidity calculation which is data munging.
Who is the target audience and what are scientific applications of this package? health and medical science researchers, public health, epidemiology, global health
Are there other R packages that accomplish the same thing? If so, how does yours differ or meet our criteria for best-in-category?
No other package manipulates ICD codes. There are some overlapping comorbidity calculation packages. 'comorbidity' is a new package. It is much slower than icd to produce the same results (see JSS vignette in 'icd'), and is more demanding of the user in setting up data in the format required (e.g. 'icd' guesses field names, and structure of ICD codes, making conversions automatically when possible). More problematically, 'comorbidity' is very generous in accepting and classifying invalid ICD codes into comorbidities. This has been thought through carefully over years in 'icd' and with feedback from the many users. The JSS article submission vignette touches on the decisions made around this.
'medicalrisk' has similar deficits to 'comorbidity'. 'pccc' is specifically focussed on comorbities of one type (pediatric complex chronic conditions), and does these also much slower than 'icd' (which also offers PCCC calculations), despite using Rcpp and parallelization.
'icd' has a carefully thought out algorithm to do this quickly which is unique in the R package ecosystem. In addition, 'icd' calculates comorbidities of more kinds, (CSS and HCC, from contributed code). 'icd' uses S3 classes to be extensible to different national and international variations of the ICD coding scheme from the WHO.
NA
Requirements
Confirm each of the following by checking the box. This package:
Publication options
[x] Do you intend for this package to go on CRAN? (it already is)
[x] NO - a JSS article has been submitted] Do you wish to automatically submit to the Journal of Open Source Software?
[x] Do you wish to submit an Applications Article about your package to Methods in Ecology and Evolution? No.
Detail
[x] Does
R CMD check
(ordevtools::check()
) succeed? Paste and describe any errors or warnings:[x] Does the package conform to rOpenSci packaging guidelines? Please describe any exceptions:
functions are named as follows:
icd::comorbid_ahrq(my_patients)
. In any case, the names of functions do not overlap with any well known functions. Previouslyexplain()
was changed toexplain_code()
for this reason.If this is a resubmission following rejection, please explain the change in circumstances: NA
If possible, please provide recommendations of reviewers - those with experience with similar packages and/or likely users of your package - and their GitHub user names:
other
There is an accompanying package called 'icd.data' which contains the rarely changing, larger data sets required for 'icd' to function. It is also on CRAN and is very simple. Should I submit a separate onboarding issue for this pacakge? Thanks.