search

ropensci / software-review

rOpenSci Software Peer Review.
295 stars 104 forks source link

RSQL #371

Closed kenarab closed 3 years ago

kenarab commented 4 years ago

Submitting Author: Alejandro Baranek (@kenarab) Leonardo Belen (@leobelen) Repository: https://github.com/rOpenStats/RSQL Version submitted: 0.1.2 Editor: TBD Reviewers: TBD

Archive: TBD
Version accepted: TBD 

Package: RSQL
Type: Package
Title: Database Agnostic Package to Generate and Process 'SQL' Queries in R
Version: 0.1.1
Language: en-US
Authors@R: c(
    person("Alejandro", "Baranek",,"abaranek@dc.uba.ar", c("cre", "aut")),
    person("Leonardo","Belen",,"leobelen@gmail.com", c("aut")))
Maintainer: Alejandro Baranek <abaranek@dc.uba.ar>
Description: Allows the user to generate and execute select, insert, update and delete 'SQL' queries the underlying database without having to explicitly write 'SQL' code. 
License: MIT + file LICENSE
Encoding: UTF-8
LazyData: true
RoxygenNote: 7.0.2
Collate:
    'sql-lib.R'
    'zzz.R'
Imports: lgr,
    R6,
    DBI, 
    RSQLite
Suggests: knitr,
    testthat,
    rmarkdown, 
    dplyr,
    covr
VignetteBuilder: knitr
BugReports: https://github.com/rOpenStats/RSQL/issues
URL: https://github.com/rOpenStats/RSQL

Scope

The objective to easily connect R code with databases without actually writing SQL code

All kind of audiences

Technical checks

Confirm each of the following by checking the box.

This package:

Publication options

JOSS Options - [ ] The package has an **obvious research application** according to [JOSS's definition](https://joss.readthedocs.io/en/latest/submitting.html#submission-requirements). - [ ] The package contains a `paper.md` matching [JOSS's requirements](https://joss.readthedocs.io/en/latest/submitting.html#what-should-my-paper-contain) with a high-level description in the package root or in `inst/`. - [ ] The package is deposited in a long-term repository with the DOI: - (*Do not submit your package separately to JOSS*)
MEE Options - [ ] The package is novel and will be of interest to the broad readership of the journal. - [ ] The manuscript describing the package is no longer than 3000 words. - [ ] You intend to archive the code for the package in a long-term repository which meets the requirements of the journal (see [MEE's Policy on Publishing Code](http://besjournals.onlinelibrary.wiley.com/hub/journal/10.1111/(ISSN)2041-210X/journal-resources/policy-on-publishing-code.html)) - (*Scope: Do consider MEE's [Aims and Scope](http://besjournals.onlinelibrary.wiley.com/hub/journal/10.1111/(ISSN)2041-210X/aims-and-scope/read-full-aims-and-scope.html) for your manuscript. We make no guarantee that your manuscript will be within MEE scope.*) - (*Although not required, we strongly recommend having a full manuscript prepared when you submit here.*) - (*Please do not submit your package separately to Methods in Ecology and Evolution*)

Code of conduct

annakrystalli commented 4 years ago

Hello @kenarab and many thanks for your submission.

We have been discussing the package and, given the variety of packages that perform similar functionality to yours, we are finding it difficult to decide whether it would be considered best in class because of the very minimal documentation.

Although you mention it has additional features to dbplyr in your submission, it is not clear from the README. Before we make a final decision, we would appreciate improvements to the documentation, demonstrating more of package functionality and how the package is different and more feature-complete than what exists already. Indeed being explicit about this in the docs would be useful for users in choosing the package, not just us. With that respect, a pkgdown documentation website would make it easier for users to browse documentation online. This is not necessary for accepting the package but I strongly recommend it.

Finally, can I ask that you please not add the rOpenSci review badge until the package has officially been accepted for review? Many thanks.

Any questions, just let me know.

kenarab commented 4 years ago

Hi @annakrystalli

We didn't find a similar package, if you know a package which can automatically generate SQL code using R code is really wellcome. dbplyr is focused in analysing data from a DB so it is focused on dplyr grammar and generates SELECTS statements. RSQL generates SELECT but, INSERT, UPDATES and DELETES. The expresiveness is limited yet but can be expanded with some work.

We will extend examples and documentation for justifying the opportunity to include this project in a so-rich community like rOpenSci.

One feature we want to explore using RSQL is to make a data.frame/data.table/tibble implementation which impacts directly on the database and not works in memory.

Finally, can I ask that you please not add the rOpenSci review badge until the package has officially been accepted for review? Many thanks.

Badge configuration already removed from readme

Best, Ale.

kenarab commented 4 years ago

@annakrystalli, Can we include co-author @leobelen in this thread, please? Maybe he be included if I only mention him. I will not answer in any case.

annakrystalli commented 4 years ago

Thanks for the response @kenarab ! I'm confident that with more detailed documentation, it will be clear that the package is within scope. Look forward to seeing more of what the package can do 🙂

And yes @leobelen should be getting notifications of this thread because you tagged him in thhe initial comment but happy to tag in every comment too if you prefer?

noamross commented 4 years ago

⚠️⚠️⚠️⚠️⚠️

In the interest of reducing load on reviewers and editors as we manage the COVID-19 crisis, rOpenSci is temporarily pausing new submissions for software peer review for 30 days (and possibly longer). Please check back here again after 17 April for updates.

In this period new submissions will not be handled, nor new reviewers assigned. Reviews and responses to reviews will be handled on a 'best effort' basis, but no follow-up reminders will be sent.

Other rOpenSci community activities continue. We express our continued great appreciation for the work of our authors and reviewers. Stay healthy and take care of one other.

The rOpenSci Editorial Board

⚠️⚠️⚠️⚠️⚠️

kenarab commented 4 years ago

It is great for me. I´m putting effort this days working on COVID-19 trying to give clues from international data to Southamerican outbreak, which is starting. There is no hurry with RSQL process.

I´m building curated series from JHU for making estimations. https://github.com/rOpenStats/COVID19

Maybe it is useful for you.

Best, Ale.

On Tue, Mar 17, 2020 at 12:03 AM Noam Ross notifications@github.com wrote:

⚠️⚠️⚠️⚠️⚠️

In the interest of reducing load on reviewers and editors as we manage the COVID-19 crisis, rOpenSci is temporarily pausing new submissions for software peer review for 30 days (and possibly longer). Please check back here again after 17 April for updates.

In this period new submissions will not be handled, nor new reviewers assigned. Reviews and responses to reviews will be handled on a 'best effort' basis, but no follow-up reminders will be sent.

Other rOpenSci community activities continue. We express our continued great appreciation for the work of our authors and reviewers. Stay healthy and take care of one other.

The rOpenSci Editorial Board

⚠️⚠️⚠️⚠️⚠️

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ropensci/software-review/issues/371#issuecomment-599852993, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWMBVXTZRP22X73RGU3ICLRH3R6TANCNFSM4K7FO5MA .

-- alejandro baranek @ken4rab https://twitter.com/ken4rab qbotics http://qbotics.tumblr.com/ | rpolyhedra https://qbotics.shinyapps.io/rpolyhedra-explorer/?_inputs_&polyhedron_color=%22%23FF0000FF%22&polyhedron_name=%22Triakis%20Tetrahedron%22&polyhedron_source=%22dmccooey%22&show_axes=false | surferinvaders http://surferinvaders.tumblr.com | algebraic-soundscapes http://imaginary.org/content/algebraic-soundscapes | surfer-shuffle http://imaginary.org/program/surfer-shuffle

annakrystalli commented 4 years ago

⚠️⚠️⚠️⚠️⚠️ In the interest of reducing load on reviewers and editors as we manage the
COVID-19 crisis, rOpenSci new submissions for software peer review are paused.

In this period new submissions will not be handled, nor new reviewers assigned.
Reviews and responses to reviews will be handled on a 'best effort' basis, but
no follow-up reminders will be sent. Other rOpenSci community activities continue.

Please check back here again after 25 May when we will be announcing plans to slowly start back up.

We express our continued great
appreciation for the work of our authors and reviewers. Stay healthy and take
care of one other.

The rOpenSci Editorial Board ⚠️⚠️⚠️⚠️⚠️

geanders commented 4 years ago

@kenarab : We have re-set to our normal mode for reviews, and I see that we had left this review with a remaining question about documentation, in particular to help us figure out if this package meets our criteria for novelty. I wanted to check back in with you to see if you had any updates.

As a note, there are guidelines available in Chapter 5 of our online book on the point we're trying to assess before deciding whether to send the package out for review, and ideally the text of the package documentation (vignettes and / or README ) will highlight novelty or significant improvements over existing packages to help us assess that:

"However, as we want packages in the rOpenSci suite to be our top recommendations for the tasks they perform, we aim to avoid duplication of functionality of existing R packages in any repo without significant improvements. An R package that replicates the functionality of an existing R package may be considered for inclusion in the rOpenSci suite if it significantly improves on alternatives in any repository (RO, CRAN, BioC) by being:

  • More open in licensing or development practices
  • Broader in functionality (e.g., providing access to more data sets, providing a greater suite of functions), but not only by duplicating additional packages
  • Better in usability and performance
  • Actively maintained while alternatives are poorly or no longer actively maintained
  • These factors should be considered as a whole to determine if the package is a significant improvement. A new package would not meet this standard only by following our package guidelines while others do not, unless this leads to a significant difference in the areas above.

We recommend that packages highlight differences from and improvements over overlapping packages in their README and/or vignettes."

maelle commented 4 years ago

:wave: @kenarab, any update?

maelle commented 3 years ago

:wave: @kenarab (and happy new year, as much as possible), any update?

maelle commented 3 years ago

:wave: @kenarab, any update?

maelle commented 3 years ago

Closing this as the latest response was more than one year ago.

kenarab commented 3 years ago

I'm sorry. We are quite busy and this project is right now frozen. Maybe we will have time in the near future for continuing with the submission process, we have to review what has been made with this kind of tools. We will contact you later on this month.

Best regards, Alejandro.

On Thu, Feb 11, 2021 at 4:50 AM Maëlle Salmon @.***> wrote:

👋 @kenarab https://github.com/kenarab, any update?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ropensci/software-review/issues/371#issuecomment-777258254, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWMBVT5K2GRVXHKYEV3G23S6OD5PANCNFSM4K7FO5MA .

-- alejandro baranek @ken4rab https://twitter.com/ken4rab qbotics http://qbotics.tumblr.com/ | rpolyhedra https://qbotics.shinyapps.io/rpolyhedra-explorer/?_inputs_&polyhedron_color=%22%23FF0000FF%22&polyhedron_name=%22Triakis%20Tetrahedron%22&polyhedron_source=%22dmccooey%22&show_axes=false | surferinvaders http://surferinvaders.tumblr.com | algebraic-soundscapes http://imaginary.org/content/algebraic-soundscapes | surfer-shuffle http://imaginary.org/program/surfer-shuffle