Closed maelle closed 8 years ago
Thanks for your submission! Seeking reviewers now
Reviewers: @geanders Due date: 2016-05-18
@geanders Due date: 2016-05-18 - hey there, it's been 16 days, please get your review in by May 18, thanks :smiley_cat: (ropensci-bot)
Overall, the package is short and sweet, with 3 cleanly coded and well-named functions. I would certainly use this package in my own research and recommend it to others. The documentation, both on the README page for the GitHub repository and in the vignette, gives an appropriate amount of details on the data that’s being pulled and the source from which it came (although, see a few minor notes below about a few points in the data description to clarify) and includes a prominently-placed link to the source’s website for users who want more information on the original data. I have only a few minor suggestions for improvements.
riem_measures
help file— from looking at the output, I’m pretty sure it’s in %). Finally, could you give a link or some other help to users for how to decrypt the weather codes (one of the variables returned)?riem_stations
that users can see a map with all stations available for a network at the IEM website. For some users, that might be an easier way to search for the codes to use with riem_measures
. riem_stations
, make sure that it’s clear that you can only put in a single network at a time. Some users might try to put in a vector of several networks, if they want to pull for several countries at a time. Currently, it’s not completely clear from the documentation that you can’t do this, and the error message if you try would be cryptic to many users, I think. strsplit
to split up the dates in riem_measures
, but if lubridate is already a dependency, why not just use functions from that to process the date? I would think the ymd
function would give a little more leniency in how users input the date (for example, could probably process “2000-01-01” and “2000/01/01”). Then you could use year
, month
and mday
to pull out the elements you want. @importFrom
.Thanks a lot, @geanders! 😀 I will improve the pkg this week!
@geanders Due date: 2016-05-18 - hey there, it's been 21 days, please get your review in soon, thanks :smiley_cat: (ropensci-bot)
I've now taken Brooke's feedback into account, which was a pleasure, thanks a lot again for your useful feedback and your enthusiasm! I have added you as a reviewer in the DESCRIPTION file.
strsplit
to lubridate
functions, this is a really good idea!@geanders & @sckott I'll now wait for further steps.
@geanders sorry about the 2nd bot ping https://github.com/ropensci/onboarding/issues/39#issuecomment-219893706 - still working out bugs in the system
@masalmon I'll have a quick look today and get back to you
Looks great. Just a few things before accepting::
.Rbuildignore
this
✔ checking DESCRIPTION meta-information
N checking top-level files
Non-standard file/directory found at top level:
‘README.Rmd’
Are these warnings a problem?
Testing riem
measures: ..........................W.W.W.W..
networks: ...
stations: ......
Warnings -----------------------------------------------------------------------
1. riem_measures checks dates (@test-measures.R#41) - All formats failed to parse. No formats found.
2. riem_measures checks dates (@test-measures.R#43) - All formats failed to parse. No formats found.
3. riem_measures checks dates (@test-measures.R#45) - All formats failed to parse. No formats found.
4. riem_measures checks dates (@test-measures.R#47) - All formats failed to parse. No formats found.
Examples took a while to run
^@✔ checking examples
Examples with CPU or elapsed time > 5s
user system elapsed
riem_measures 0.591 0.12 17.429
but it could just be my slow hotel internet - if you don't get a time warning, then nevermind
Danke!
Moreover,
@akrherz thanks again for the help about the IEM website!
dont need to ruildignore https://github.com/masalmon/riem/blob/master/.Rbuildignore#L5
you may want to have some examples not in \dontrun - cran folks sometimes complain about lack of egs not in dontrun, but mostly they dont complain
Would it be ok to have examples using a website in dontrun? I'd rather let them in dontrun... Well but CRAN folks don't know I have CI running the examples on a regular basis... I'm undecided.
In opencage all examples are in \dontrun and they didn't complain. So I might try with dontrun for a first submission!
Okay, sounds good.
@masalmon accepted, transfer to ropenscilabs when you get a chance :)
Hi, I'm no R expert (or coding, really), but my database runs this package at 6 am in the morning to grab yesterday's wind and temp. But it can only get hours 1-20. 21-24 never come in. Do the rest of the hours of the previous day get published after 6am EST? How do I get those last few hours?
Hi @gregfortress, please file your issue over at the package repository: https://github.com/ropensci/riem/issues . This is a closed thread from a previous package review; that is the appropriate place for ongoing questions/issues.
@ropensci-review-bot check readme
@ropensci-review-bot check readme
@ropensci-review-bot check readme
@ropensci-review-bot check readme
{}
This package allows to get METAR reports (weather reports) through the Iowa Environment Mesonet https://mesonet.agron.iastate.edu/request/download.phtml?network=IN__ASOS
Iowa Environment Mesonet https://mesonet.agron.iastate.edu/request/download.phtml?network=IN__ASOS
Anyone needing weather data
The R package wunderground allows to access weather data including ASOS stations but the API only allows a linited number of calls per day/minute.
devtools
install instructionsdevtools::check()
produce any errors or warnings? If so paste them below.