ropensci / software-review

rOpenSci Software Peer Review.
292 stars 104 forks source link

Presubmission inquiry: Is toolbox.E3D in scope? #392

Closed jonaslenz closed 4 years ago

jonaslenz commented 4 years ago

Submitting Author: Jonas Lenz (@jonaslenz)
Repository: https://github.com/jonaslenz/toolbox.e3d


Package: toolbox.e3d
Type: Package
Title: Toolbox for the soil erosion modeling tool EROSION-3D
Version: 0.0.0.90
Author: Jonas Lenz
Maintainer: Jonas Lenz <jonaspunktlenz@gmail.com>
Description: A R wrapper package for the soil erosion modelling tool EROSION-3D (available from Geognostics at http://www.geognostics.de/e3d_demo.html).
  Supports reproducable work with EROSION-3D via command line.
  Automates common workflows (iteration of calibration parameters).
URL: https://github.com/jonaslenz/toolbox.e3d
BugReports: https://github.com/jonaslenz/toolbox.e3d/issues
License: GPL-3
Depends: R (>= 3.3.4)
Encoding: UTF-8
LazyData: true
RoxygenNote: 7.1.0
Imports: raster, ini
Suggests: 
    testthat (>= 2.1.0),
    knitr,
    rmarkdown
VignetteBuilder: knitr

Scope

scientific software wrappers The package allows users to reproducable run EROSION-3D from R, which is used up to now mainly through a GUI.

workflow automation A key feature of the package is the automated determination of calibration parameters, which is currently done in a tedious manual iteration process.

Users of EROSION-3D. Enchance reproducability, parameter determination for large datasets.

No.

Not applicable.

I want to ask if this package may be in scope. There are some potential issues and not all can be solved by me:

  1. EROSION-3D is not open-source. Software and licence is available from Geognostics at http://www.geognostics.de/e3d_demo.html. (Licence for review purpose will be available free of charge.)
    1. A documentation of the command line interface of EROSION-3D is not realy existent. Model settings used in the package were explored in a trial and error process and with support of developers of EROSION-3D.
    2. Tests and CI/CD are not implemented now.
geanders commented 4 years ago

@jonaslenz : Thanks very much for your submission as well as your clear explanation of some of the potential issues!

A key question will likely be that the software being wrapped is not open-source, as you have pointed out. I will discuss with the rest of the editorial team, and we may have some more questions and clarifications to ask of you.

In the mean time, you may also want to check the section on "scientific software wrappers" in the rOpenSci Packages book, as this has a note about this open-source/not open-source question and points to a couple of examples of exceptions.

jonaslenz commented 4 years ago

@geanders : thank you very much for your response and the hint to the software wrapping section.

regarding this section, I wan't to give a hopefully helpful description of the wrapped software EROSION-3D:

maelle commented 4 years ago

:wave: @jonaslenz sorry for the delay and thanks for your answer. Because of the existence of open-source alternatives to EROSION-3D, ultimately we decided that your package is out-of-scope. Thanks again for your submission and good luck with further development!