ropensci / software-review

rOpenSci Software Peer Review.
292 stars 104 forks source link

rdbhapi package: An R package to simplify API access to data on higher education in Norway #442

Closed mni-hkdir closed 3 years ago

mni-hkdir commented 3 years ago

Submitting Author: Marija Ninic (@makinin)
Other Package Authors: Sigve Hofland Berge (@sigve-berge-hofland) Repository: https://github.com/makinin/rdbhapi


Package: rdbhapi
Title: Interface to 'DBH-API' 
Version: 2.1.0
Authors@R: c(person(given = "Marija",family = "Ninic",role = c("cre", "aut"),email = "marija.ninic@nsd.no", comment=c(ORCID ="0000-0001-8484-5817")),person(given=c("Sigve", "Hofland"), family="Berge", role = "aut"))
Description: Downloads 'DBH-API'<https://dbh.nsd.uib.no/tjenester.action> data as dataframes. These data are in machine-readable format and provides information about education, finances, research and publications. 
License: MIT + file LICENSE
Encoding: UTF-8
RoxygenNote: 7.1.1
Imports: 
    httr,
    readr,
    rjson,
    jsonlite,
    rlang,
    stats
Suggests:
    spelling, 
    knitr,
    rmarkdown,
    testthat
VignetteBuilder: knitr
Language: en-US

Scope

maelle commented 3 years ago

:wave: @makinin thanks for your submission, but you forgot to fill out parts of the template / to answer some of the questions. :slightly_smiling_face:

maelle commented 3 years ago

:wave: @makinin could you please update the submission to answer all applicable questions in the template?

mni-hkdir commented 3 years ago

How to add Technical checks, Publication options, MEE Options, Code of conduct, can not find them in template

maelle commented 3 years ago

@makinin I mean that in the body of the template there are questions like "Explain how and why the package falls under these categories (briefly, 1-2 sentences)." and no answer yet. :slightly_smiling_face:

Also, were you intending to fill a pre-submission inquiry rather than a submission? The template is https://github.com/ropensci/software-review/blob/master/.github/ISSUE_TEMPLATE/B-submit-a-presubmission-inquiry.md (and also has some of the questions you haven't answered yet).

mni-hkdir commented 3 years ago

It is fixed now , thank you for help :)

noamross commented 3 years ago

@makinin Thanks for making those changes and submitting a pre-submission inquirty. This does fit into our package Aims and Scope. When you want to start the review process, please fill out the full submission template here: https://github.com/ropensci/software-review/issues/new?assignees=&labels=&template=A-submit-software-for-review.md