ropensci / software-review

rOpenSci Software Peer Review.
291 stars 104 forks source link

Presubmission inquiry - stochLAB package for modelling collision risk at offshore wind farms #506

Closed grwhumphries closed 2 years ago

grwhumphries commented 2 years ago

Submitting Author Grant Humphries Reviewers: Editor: Language Code English Submitting Author: Grant Humphries (@grwhumphries)
Other Package Authors: Bruno Caneco (@bcaneco) Repository: https://github.com/HiDef-Aerial-Surveying/stochLAB Submission type: Pre-submission


Type: Package
Package: stochLAB
Title: Stochastic Collision Risk Model
Version: 1.0.0
Authors@R: c(
    person("Grant", "Humphries", , "grant.humphries@hidefsurveying.co.uk", role = c("aut", "cre")),
    person("Bruno", "Caneco", , "bruno@dmpstats.com", role = "aut"),
    person("Marine Scotland", role = c("fnd", "cph")),
    person("HiDef", role = "cph"),
    person("DMPstats", role = "cph")
  )
Description: Tool for running Collision Risk Models for seabirds on
    offshore wind farms.
License: GPL (>= 3) + file LICENSE
Depends: 
    R (>= 4.0)
Imports: 
    cli,
    data.table,
    dplyr,
    foreach,
    glue,
    logr,
    magrittr,
    msm,
    pracma,
    purrr,
    rlang,
    stats,
    tibble,
    tidyr
Suggests: 
    rmarkdown,
    knitr,
    spelling,
    testthat (>= 3.0.0),
    covr
Config/testthat/edition: 3
Encoding: UTF-8
Language: en-GB
LazyData: true
LazyDataCompression: bzip2
Roxygen: list(markdown = TRUE)
URL: https://www.github.com/HiDef-Aerial-Surveying/stochLAB,
    https://hidef-aerial-surveying.github.io/stochLAB/
BugReports: https://www.github.com/HiDef-Aerial-Surveying/stochLAB/issues
RoxygenNote: 7.1.2
VignetteBuilder: knitr

Scope

ropensci-review-bot commented 2 years ago

The submission template is missing the following values: author1, language

jooolia commented 2 years ago

Dear @grwhumphries, Thank you for your pre-submission. This is a statistical package submission and you have replied "no" to the documentation of standards in your code, is this something you intend to do before a full submission or do you need support with this point? Thanks, Julia

grwhumphries commented 2 years ago

Thanks @jooolia :) I might need a bit of support with that, if at all possible. Not a process I've followed before. I'm guessing this is done through the srr package as noted in the presubmission inquiry document?

jooolia commented 2 years ago

Yes it would be with the srr package.

I was having a look at the Readme.Rmd and the vignette to get a feel for the outputs and struggled to use them as most of the code snippets are not R chunks and when I change them to R chunks I get several errors. I will try to have a look using some of the examples provided in other files, but it would be nice to clarify why this is not working.

Thanks, Julia

jooolia commented 2 years ago

Hi @mpadge, you mentioned being in touch about this issue, are there any updates here? Thanks, Julia

mpadge commented 2 years ago

Yes, I think we can close this now, as @grwhumphries intends to proceed to a full submission. Right Grant?

grwhumphries commented 2 years ago

@mpadge - yeah that's correct! I'll be doing a full submission soon

mpadge commented 2 years ago

Thanks @grwhumphries, we'll close this issue and look forward to your full submission. Feel free to ask questions along the way.