search

ropensci / software-review

rOpenSci Software Peer Review.
291 stars 104 forks source link

Fix template variables for pre-submission enquiries #507

Closed mpadge closed 2 years ago

mpadge commented 2 years ago

@maelle Current templates do not have the same HTML variables as the main submission templates, which is why the bot always responds with "missing variables". This rectifies variables in all templates. Doing so then automatically enables the initial_variables responder in buffy to be triggered (and which will then only respond if these have been deleted), but more importantly will allow @ropensci-review-bot check package to be called from pre-submission issues as well, which could be very useful.

Could you please check all templates very thoroughly, to ensure I've not made any mistakes or types here? Thanks:smile:

Note that buffy's initial_values responder is run on all submissions, but could easily be restricted like we have for the welcome responder. I think this is okay, as it will ensure that package checks can be run, but please have a think about alternatives there too?

maelle commented 2 years ago

I think this is okay, as it will ensure that package checks can be run, but please have a think about alternatives there too?

It sounds ok for me too.

mpadge commented 2 years ago

Thanks @maelle, I accepted your suggestions. Can you please now merge if you approve