ropensci / software-review

rOpenSci Software Peer Review.
292 stars 104 forks source link

remotePARTs code review inquiry #563

Closed morrowcj closed 11 months ago

morrowcj commented 1 year ago

Submitting Author Name: Clay Morrow Submitting Author Github Handle: !--author1-->@morrowcj<!--end-author1-- Other Package Authors Github handles: !--author-others-->@arives<!--end-author-others-- Repository: https://github.com/morrowcj/remotePARTS Submission type: Pre-submission Language: en


Package: remotePARTS
Title: Spatiotemporal Autoregression Analyses for Large Data Sets
Version: 1.0.0
Authors@R: 
    c(person(given = "Clay",
           family = "Morrow",
           role = c("aut", "cre"),
           email = "morrowcj@outlook.com",
           comment = c(ORCID = "0000-0002-3069-3296")),
      person(given = "Anthony",
           family = "Ives",
           role = c("aut"),
           email = "arives@wisc.edu",
           comment = c(ORCID = "0000-0001-9375-9523")))
Description: 
  These tools were created to test map-scale hypotheses about trends in large 
  remotely sensed data sets but any data with spatial and temporal variation
  can be analyzed. Tests are conducted using the PARTS method for analyzing spatially
  autocorrelated time series 
  (Ives et al., 2021: <doi:10.1016/j.rse.2021.112678>). 
  The method's unique approach can handle extremely large data sets that other 
  spatiotemporal models cannot, while still appropriately accounting for 
  spatial and temporal autocorrelation. This is done by partitioning the data 
  into smaller chunks, analyzing chunks separately and then combining the 
  separate analyses into a single, correlated test of the map-scale hypotheses.
URL: https://github.com/morrowcj/remotePARTS
BugReports: https://github.com/morrowcj/remotePARTS/issues
License: GPL (>= 3)
Encoding: UTF-8
LazyData: TRUE
RoxygenNote: 7.2.2
Depends: R (>= 4.0)
Imports: 
  stats,
  geosphere (>= 1.5.10), 
  Rcpp (>= 1.0.5), 
  CompQuadForm,
  foreach,
  parallel,
  iterators, 
  doParallel
Suggests: 
    dplyr (>= 1.0.0),
    data.table,
    knitr,
    rmarkdown,
    markdown,
    sqldf,
    devtools,
    ggplot2,
    reshape2
LinkingTo: Rcpp, RcppEigen
VignetteBuilder: knitr

Scope

This package is an implementation of our spatial and spetiotemporal statistical method for hypothesis testing (Ives et al 2021).

No. I just learned of rOpenSci.

Scientists - primarily Ecologists and Earth Scientists.

No. While there are other packages that perform spatiotemporal analyses (e.g., R-INLA for a Bayesian approach), traditional methods cannot be feasibly applied to large datasets due to the computational power required to invert the $N \times N$ distance matrices (who's computational complexity scales with $N^3$) for $N$ spatial locations. This method uses a novel approach to reduce the complexity, allowing for hypothesis testing with incredibly large datasets.

Yes.

This is my first full-fledged package. The main driver functions are written in C++ (using the Rcpp framework), a language that I had never written code with before. When used (incorrectly) the package will occasionally crash R ("R Session Aborted") and I'm not sure why. I would like help fixing this problem and improving the package more generally.

morrowcj commented 1 year ago

I learned of rOpenSci while submitting a manuscript to Methods in Ecology and Evolution.

annakrystalli commented 1 year ago

Dear @morrowcj ,

Many thanks for your pre-submission enquiry!

The editorial team has concluded that the package definitely fits in our "stats" scope.

To confirm everything is okay however, before moving to full submission, we do suggest going through the formal process of documenting compliance with the stats standards. You can call @ropensci-review-bot check srr in this issue to confirm documentation has been completed successfully. You can find more details in our documentation.

maurolepore commented 1 year ago

Dear @morrowcj,

Today starts my rotation as EiC meaning the role of @annakrystalli is now mine. Did you have the chance to follow up on the comment above?

morrowcj commented 1 year ago

Hello, @maurolepore:

I have not yet had time to address this yet. It is on my list of tasks but I'm pretty swamped with other projects at the moment. I hope to get back to this by the end of next month. Sorry.

maelle commented 1 year ago

@morrowcj Hello, I'm the new current editor-in-chief :smile_cat: Any update?

morrowcj commented 1 year ago

@maelle, unfortunately, this is still on the back-burner for me at present. My apologies. We are re-evaluating our options for publishing. We're considering JOS, which - if I understand correctly - will perform a code review for us. If we go that route, following through with this process would be redundant.

maelle commented 1 year ago

@morrowcj if your package is reviewed by rOpenSci and is in scope for JOSS (is it what you mean by JOS?), then the process at JOSS is expedited. rOpenSci review is more thorough. Not to put any pressure on you, just to give some more info. :smile_cat:

morrowcj commented 1 year ago

@maelle, Yes I did mean JOSS. I did not know that! This is very useful information. Thank you.

maelle commented 1 year ago

@morrowcj did you have time to make any decision? :smile_cat:

maelle commented 1 year ago

@morrowcj friendly reminder :smile_cat:

jhollist commented 11 months ago

@morrowcj I am currently serving as the rOpenSci EIC and just wanted to check in on this. Have you made a decision on this submission? Thanks!

morrowcj commented 11 months ago

@jhollist, Yes, I think we decided, for now, that we don't want to proceed. Thank you!