ropensci / software-review

rOpenSci Software Peer Review.
286 stars 104 forks source link

waywiser: Ergonomic Methods for Assessing Spatial Models #565

Closed mikemahoney218 closed 1 year ago

mikemahoney218 commented 1 year ago

Submitting Author Name: Michael Mahoney Submitting Author Github Handle: !--author1-->@mikemahoney218<!--end-author1-- Repository: https://github.com/mikemahoney218/waywiser Submission type: Pre-submission Language: en


Type: Package
Package: waywiser
Title: Ergonomic Methods for Assessing Spatial Models
Version: 0.2.0.9000
Authors@R: c(
    person("Michael", "Mahoney", , "mike.mahoney.218@gmail.com", role = c("aut", "cre"),
           comment = c(ORCID = "0000-0003-2402-304X")),
    person("Lucas", "Johnson", , "lucas.k.johnson03@gmail.com", role = c("ctb"),
           comment = c(ORCID = "0000-0002-7953-0260")),
    person("RStudio", role = c("cph", "fnd"))
  )
Description: Assessing predictive models of spatial data can be challenging, 
    both because these models are typically built for extrapolating outside the
    original region represented by training data and due to potential spatially
    structured errors, with "hot spots" of higher than expected error
    clustered geographically due to spatial structure in the underlying
    data. Methods are provided for assessing models fit to spatial data, 
    including approaches for measuring the spatial structure of model errors,
    assessing model predictions at multiple spatial scales, and evaluating where 
    predictions can be made safely. Methods are particularly useful for models 
    fit using the 'tidymodels' framework. Methods include Moran's I
    ('Moran' (1950) <doi:10.2307/2332142>), Geary's C 
    ('Geary' (1954) <doi:10.2307/2986645>), Getis-Ord's G
    ('Ord' and 'Getis' (1995) <doi:10.1111/j.1538-4632.1995.tb00912.x>),
    agreement coefficients from Ji and Gallo (2006) 
    (<doi: 10.14358/PERS.72.7.823>), agreement metrics from Willmott (1981)
    (<doi: 10.1080/02723646.1981.10642213>) and Willmott et al. (2012)
    (<doi: 10.1002/joc.2419), an implementation of the area of applicability 
    methodology from 'Meyer' and 'Pebesma' (2021) 
    (<doi:10.1111/2041-210X.13650>), and an implementation of
    multi-scale assessment as described in 'Riemann' et al. (2010)
    (<doi:10.1016/j.rse.2010.05.010>).
License: MIT + file LICENSE
URL: https://github.com/mikemahoney218/waywiser,
    https://mikemahoney218.github.io/waywiser/
BugReports: https://github.com/mikemahoney218/waywiser/issues
Depends: 
    R (>= 3.6)
Imports: 
    dplyr,
    fields,
    FNN,
    glue,
    hardhat,
    Matrix,
    purrr,
    rlang,
    rsample,
    sf (>= 1.0-0),
    spdep (>= 1.1-9),
    stats,
    tibble,
    tidyselect,
    yardstick
Suggests: 
    applicable,
    caret,
    CAST,
    covr,
    ggplot2,
    knitr,
    modeldata,
    recipes,
    rmarkdown,
    spatialsample,
    spelling,
    testthat (>= 3.0.0),
    tidymodels,
    tidyr,
    tigris,
    vip,
    whisker,
    withr
Config/testthat/edition: 3
Config/testthat/parallel: true
Encoding: UTF-8
LazyData: true
Roxygen: list(markdown = TRUE, roclets = c("namespace", "rd", "srr::srr_stats_roclet"))
RoxygenNote: 7.2.3
Language: en-US
VignetteBuilder: knitr

Scope

waywiser is a toolkit for assessing spatial models, providing a standardized, ergonomic interface to use multiple pre-existing assessment techniques, with a particular focus on integrating with and feeling similar to the tidymodels ecosystem. While many of these techniques are not exclusively spatial, they all originally emerge from spatial modeling research.

Yes!

Anyone fitting models to spatial data, particularly (but not exclusively) people working within the tidymodels ecosystem. This includes a number of domains, and we've already been using it in our modeling practice.

Individual pieces of this package have been implemented elsewhere:

I am not aware of implementations of:

That said, the primary goal of this package is to provide a standardized interface around all of these tasks, making the user interface as consistent as possible. This also allows for greater integration with tidymodels. Additionally, as discussed in ?ww_area_of_applicability, there are some differences in the AOA implementation in this package versus in CAST.

N/A

annakrystalli commented 1 year ago

@ropensci-review-bot check srr

ropensci-review-bot commented 1 year ago

Note: The following R packages were unable to be installed/upgraded on our system: [tigris, spatialsample, spdep]; some checks may be unreliable.

ropensci-review-bot commented 1 year ago

'srr' standards compliance:

:heavy_check_mark: This package complies with > 50% of all standads and may be submitted.

annakrystalli commented 1 year ago

Hello @mikemahoney218 and many thanks for the pre-submission.

Many of the editors are already on a holiday break so we will get back to you with feedback in the New Year.

Enjoy your holidays!

mikemahoney218 commented 1 year ago

Happy holidays @annakrystalli :smile:

mikemahoney218 commented 1 year ago

Hi @annakrystalli ! Hope you had a good holiday period. Do you happen to know when I can expect to hear back on this submission? Not trying to rush anyone or interrupt any vacations, I'm just planning out my workload for the next few weeks :smile:

annakrystalli commented 1 year ago

Hello @mikemahoney218 ,

No worries. I can confirm we are happy to accept the package for review so feel free to make a proper submission.